public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 0/2] board: k2g: Enable ECC support
@ 2016-08-27 11:49 Lokesh Vutla
  2016-08-27 11:49 ` [U-Boot] [PATCH 1/2] board: ks2: Enable ECC using detected DDR size Lokesh Vutla
  2016-08-27 11:49 ` [U-Boot] [PATCH 2/2] board: k2g: Enable ECC byte lane Lokesh Vutla
  0 siblings, 2 replies; 7+ messages in thread
From: Lokesh Vutla @ 2016-08-27 11:49 UTC (permalink / raw)
  To: u-boot

This series enables ECC support on k2g-evm.

Lokesh Vutla (2):
  board: ks2: Enable ECC using detected DDR size
  board: k2g: Enable ECC byte lane

 arch/arm/mach-keystone/ddr3.c | 3 +--
 board/ti/ks2_evm/board.c      | 3 +++
 2 files changed, 4 insertions(+), 2 deletions(-)

-- 
2.9.3

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 1/2] board: ks2: Enable ECC using detected DDR size
  2016-08-27 11:49 [U-Boot] [PATCH 0/2] board: k2g: Enable ECC support Lokesh Vutla
@ 2016-08-27 11:49 ` Lokesh Vutla
  2016-08-30 11:20   ` Tom Rini
  2016-10-03 13:37   ` [U-Boot] [U-Boot, " Tom Rini
  2016-08-27 11:49 ` [U-Boot] [PATCH 2/2] board: k2g: Enable ECC byte lane Lokesh Vutla
  1 sibling, 2 replies; 7+ messages in thread
From: Lokesh Vutla @ 2016-08-27 11:49 UTC (permalink / raw)
  To: u-boot

EEC is being enabled based on the ddr size populated by SPD data.
But not all keystone platforms have SPD data to detect ddr3 size.
So, enable ECC using the detected DDR size.

Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 board/ti/ks2_evm/board.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/board/ti/ks2_evm/board.c b/board/ti/ks2_evm/board.c
index 1de7df0..03254e1 100644
--- a/board/ti/ks2_evm/board.c
+++ b/board/ti/ks2_evm/board.c
@@ -50,6 +50,9 @@ int dram_init(void)
 
 	if (ddr3_size)
 		ddr3_init_ecc(KS2_DDR3A_EMIF_CTRL_BASE, ddr3_size);
+	else
+		ddr3_init_ecc(KS2_DDR3A_EMIF_CTRL_BASE, gd->ram_size >> 30);
+
 	return 0;
 }
 
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] board: k2g: Enable ECC byte lane
  2016-08-27 11:49 [U-Boot] [PATCH 0/2] board: k2g: Enable ECC support Lokesh Vutla
  2016-08-27 11:49 ` [U-Boot] [PATCH 1/2] board: ks2: Enable ECC using detected DDR size Lokesh Vutla
@ 2016-08-27 11:49 ` Lokesh Vutla
  2016-08-30 11:20   ` Tom Rini
  2016-10-03 13:37   ` [U-Boot] [U-Boot,2/2] " Tom Rini
  1 sibling, 2 replies; 7+ messages in thread
From: Lokesh Vutla @ 2016-08-27 11:49 UTC (permalink / raw)
  To: u-boot

Enable ECC byte lane for k2g-evm

Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 arch/arm/mach-keystone/ddr3.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mach-keystone/ddr3.c b/arch/arm/mach-keystone/ddr3.c
index 34606f4..6b92530 100644
--- a/arch/arm/mach-keystone/ddr3.c
+++ b/arch/arm/mach-keystone/ddr3.c
@@ -65,9 +65,8 @@ void ddr3_init_ddrphy(u32 base, struct ddr3_phy_config *phy_cfg)
 	while ((__raw_readl(base + KS2_DDRPHY_PGSR0_OFFSET) & 0x1) != 0x1)
 		;
 
-	/* Disable ECC for K2G */
 	if (cpu_is_k2g()) {
-		clrbits_le32(base + KS2_DDRPHY_DATX8_4_OFFSET, 0x1);
+		setbits_le32(base + KS2_DDRPHY_DATX8_4_OFFSET, 0x1);
 		clrbits_le32(base + KS2_DDRPHY_DATX8_5_OFFSET, 0x1);
 		clrbits_le32(base + KS2_DDRPHY_DATX8_6_OFFSET, 0x1);
 		clrbits_le32(base + KS2_DDRPHY_DATX8_7_OFFSET, 0x1);
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 1/2] board: ks2: Enable ECC using detected DDR size
  2016-08-27 11:49 ` [U-Boot] [PATCH 1/2] board: ks2: Enable ECC using detected DDR size Lokesh Vutla
@ 2016-08-30 11:20   ` Tom Rini
  2016-10-03 13:37   ` [U-Boot] [U-Boot, " Tom Rini
  1 sibling, 0 replies; 7+ messages in thread
From: Tom Rini @ 2016-08-30 11:20 UTC (permalink / raw)
  To: u-boot

On Sat, Aug 27, 2016 at 05:19:15PM +0530, Lokesh Vutla wrote:

> EEC is being enabled based on the ddr size populated by SPD data.
> But not all keystone platforms have SPD data to detect ddr3 size.
> So, enable ECC using the detected DDR size.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160830/6ec6d20a/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] board: k2g: Enable ECC byte lane
  2016-08-27 11:49 ` [U-Boot] [PATCH 2/2] board: k2g: Enable ECC byte lane Lokesh Vutla
@ 2016-08-30 11:20   ` Tom Rini
  2016-10-03 13:37   ` [U-Boot] [U-Boot,2/2] " Tom Rini
  1 sibling, 0 replies; 7+ messages in thread
From: Tom Rini @ 2016-08-30 11:20 UTC (permalink / raw)
  To: u-boot

On Sat, Aug 27, 2016 at 05:19:16PM +0530, Lokesh Vutla wrote:

> Enable ECC byte lane for k2g-evm
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160830/5e0a83c5/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [U-Boot, 1/2] board: ks2: Enable ECC using detected DDR size
  2016-08-27 11:49 ` [U-Boot] [PATCH 1/2] board: ks2: Enable ECC using detected DDR size Lokesh Vutla
  2016-08-30 11:20   ` Tom Rini
@ 2016-10-03 13:37   ` Tom Rini
  1 sibling, 0 replies; 7+ messages in thread
From: Tom Rini @ 2016-10-03 13:37 UTC (permalink / raw)
  To: u-boot

On Sat, Aug 27, 2016 at 05:19:15PM +0530, Lokesh Vutla wrote:

> EEC is being enabled based on the ddr size populated by SPD data.
> But not all keystone platforms have SPD data to detect ddr3 size.
> So, enable ECC using the detected DDR size.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161003/debada40/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [U-Boot,2/2] board: k2g: Enable ECC byte lane
  2016-08-27 11:49 ` [U-Boot] [PATCH 2/2] board: k2g: Enable ECC byte lane Lokesh Vutla
  2016-08-30 11:20   ` Tom Rini
@ 2016-10-03 13:37   ` Tom Rini
  1 sibling, 0 replies; 7+ messages in thread
From: Tom Rini @ 2016-10-03 13:37 UTC (permalink / raw)
  To: u-boot

On Sat, Aug 27, 2016 at 05:19:16PM +0530, Lokesh Vutla wrote:

> Enable ECC byte lane for k2g-evm
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161003/db17f826/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-10-03 13:37 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-27 11:49 [U-Boot] [PATCH 0/2] board: k2g: Enable ECC support Lokesh Vutla
2016-08-27 11:49 ` [U-Boot] [PATCH 1/2] board: ks2: Enable ECC using detected DDR size Lokesh Vutla
2016-08-30 11:20   ` Tom Rini
2016-10-03 13:37   ` [U-Boot] [U-Boot, " Tom Rini
2016-08-27 11:49 ` [U-Boot] [PATCH 2/2] board: k2g: Enable ECC byte lane Lokesh Vutla
2016-08-30 11:20   ` Tom Rini
2016-10-03 13:37   ` [U-Boot] [U-Boot,2/2] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox