From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peng Fan <van.freenix@gmail.com>
Date: Sat, 8 Oct 2016 09:57:03 +0800
Subject: [U-Boot] [PATCH] dm: ehci-mx6: support driver model
In-Reply-To: <CAD6G_RQ2RFtowMK0vgNCwzST9tc3dq2ckb4=oaBCzFLEpTTezQ@mail.gmail.com>
References: <1466144367-32702-1-git-send-email-peng.fan@nxp.com>
 <CAPnjgZ2nMefpHmTjaPj+QnLXSopakdStU1OyAVphxN=hTVWPnA@mail.gmail.com>
 <20160620014531.GA1450@linux-7smt.suse>
 <CAD6G_RQ2RFtowMK0vgNCwzST9tc3dq2ckb4=oaBCzFLEpTTezQ@mail.gmail.com>
Message-ID: <20161008015701.GB4797@linux-7smt.suse>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Jagan,
On Thu, Sep 29, 2016 at 05:38:32PM +0530, Jagan Teki wrote:
>Hi Peng,
>
>On Mon, Jun 20, 2016 at 7:15 AM, Peng Fan <van.freenix@gmail.com> wrote:
>> Hi Simon,
>>
>> On Fri, Jun 17, 2016 at 04:59:49PM -0600, Simon Glass wrote:
>>>Hi Peng,
>>>
>>>On 17 June 2016 at 00:19, Peng Fan <van.freenix@gmail.com> wrote:
>>>> Support driver model for ehci mx6 driver.
>>>> Consolidate code to be shared between DM and non-DM, such as
>>>> introducing ehci_mx6_common_init.
>>>> For simplicity, some old fasion code are keeped for DM usage,
>>>> such as board_ehci_power and board_usb_phy_mode. And 'dr-mode',
>>>> usbphy and vbus handling code for DM is not added now.
>>>> These will be added in future patches.
>>>>
>>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>>> Cc: Marek Vasut <marex@denx.de>
>>>> Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
>>>> Cc: Stefan Agner <stefan@agner.ch>
>>>> Cc: Simon Glass <sjg@chromium.org>
>>>> ---
>>>>  drivers/usb/host/ehci-mx6.c | 144 +++++++++++++++++++++++++++++++++++++++-----
>>>>  1 file changed, 130 insertions(+), 14 deletions(-)
>>>
>>>Reviewed-by: Simon Glass <sjg@chromium.org>
>>>
>>>Good start. Do you have a plan to drop the board_...() functions?
>>
>> Yeah. I'll drop the board_ functions for dt+dm for ehci-mx6 in following
>> up patches.
>
>Have you tested this? Do we have any board that using this dm driver.
>It's not working for me may be I would have add vbus-supply or
>something.

Sorry for late reply. I tested it. I have not upstream any board that use this dm driver.
The board_ functions are needed when you using this driver, I did not remove this.

Regards,
Peng.

>
>thanks!
>-- 
>Jagan Teki
>Free Software Engineer | www.openedev.com
>U-Boot, Linux | Upstream Maintainer
>Hyderabad, India.