public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] ti: common: board_detect: Replace hardcoded value with macro
Date: Tue, 11 Oct 2016 12:39:03 -0500	[thread overview]
Message-ID: <20161011173905.26208-2-nm@ti.com> (raw)
In-Reply-To: <20161011173905.26208-1-nm@ti.com>

We should have used TI_DEAD_EEPROM_MAGIC in the first place.

Fixes: d3b98a9eb941 ("ti: common: dra7: Add standard access for board description EEPROM")
Signed-off-by: Nishanth Menon <nm@ti.com>
---
 board/ti/common/board_detect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/ti/common/board_detect.c b/board/ti/common/board_detect.c
index e0ae1a51a6a4..7c552d20656a 100644
--- a/board/ti/common/board_detect.c
+++ b/board/ti/common/board_detect.c
@@ -171,7 +171,7 @@ int __maybe_unused ti_i2c_eeprom_dra7_get(int bus_addr, int dev_addr)
 		goto already_read;
 
 	/* Initialize with a known bad marker for i2c fails.. */
-	ep->header = 0xADEAD12C;
+	ep->header = TI_DEAD_EEPROM_MAGIC;
 	ep->name[0] = 0x0;
 	ep->version[0] = 0x0;
 	ep->serial[0] = 0x0;
-- 
2.10.0

  reply	other threads:[~2016-10-11 17:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-11 17:39 [U-Boot] [PATCH 0/3] ti: common: board_detect: basic fixes for blank eeprom Nishanth Menon
2016-10-11 17:39 ` Nishanth Menon [this message]
2016-10-13  3:44   ` [U-Boot] [PATCH 1/3] ti: common: board_detect: Replace hardcoded value with macro Lokesh Vutla
2016-10-13 13:42   ` Tom Rini
2016-11-02 14:25   ` [U-Boot] [U-Boot, " Tom Rini
2016-10-11 17:39 ` [U-Boot] [PATCH 2/3] ti: common: board_detect: Setup initial default value for config as well Nishanth Menon
2016-10-13  3:45   ` Lokesh Vutla
2016-10-13 13:43   ` Tom Rini
2016-11-02 14:26   ` [U-Boot] [U-Boot, " Tom Rini
2016-10-11 17:39 ` [U-Boot] [PATCH 3/3] ti: common: board_detect: Return a valid empty string for un-initialized eeprom Nishanth Menon
2016-10-13  3:45   ` Lokesh Vutla
2016-10-13 13:50   ` Tom Rini
2016-11-02 14:26   ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161011173905.26208-2-nm@ti.com \
    --to=nm@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox