[U-Boot] [PATCH 2/3] ext4: Fix handling of direntlen in unlink_filename

Tom Rini
2016-10-13T14:14:43Z

On Sun, Oct 09, 2016 at 08:15:27PM +0200, Stefan Br?ns wrote:

> The direntlen checks were quite bogus, i.e. the loop termination used
> "len + offset == blocksize" (exact match only), and checked for a
> direntlen less than 0. The latter can never happen as the len is
> unsigned, this has been reported by Coverity, CID 153384.
>
> Use the same code as in search_dir for directory traversal. This code
> has the correct checks for direntlen >= sizeof(struct dirent), and
> offset < blocksize.
>
> Signed-off-by: Stefan Br?ns <stefan.bruens@rwth-aachen.de>

Reported-by: Coverity (CID: 153383, 153384)
Reviewed-by: Tom Rini <trini@konsulko.com>

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161013/b1767802/attachment.sig>