From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pci: Move CONFIG_PCI_PNP to Kconfig
Date: Fri, 14 Oct 2016 09:07:31 -0400 [thread overview]
Message-ID: <20161014130731.GJ31808@bill-the-cat> (raw)
In-Reply-To: <CAEUhbmUM=2u6NLPVk4d0HSv9ySAm8=GbxZboNKsBgoYFsT7RFw@mail.gmail.com>
On Fri, Oct 14, 2016 at 02:28:14PM +0800, Bin Meng wrote:
> Hi Tom,
>
> On Wed, Oct 12, 2016 at 8:46 PM, Tom Rini <trini@konsulko.com> wrote:
> > On Sun, Oct 09, 2016 at 10:04:33PM -0700, Bin Meng wrote:
> >
> >> Introduce CONFIG_PCI_PNP in Kconfig and move over boards' defconfig
> >> to use that.
> >>
> >> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > [snip]
> >> 594 files changed, 460 insertions(+), 195 deletions(-)
> > [snip]
> >> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> >> index 9a7c187..7fa429b 100644
> >> --- a/drivers/pci/Kconfig
> >> +++ b/drivers/pci/Kconfig
> >> @@ -18,6 +18,11 @@ config DM_PCI_COMPAT
> >> measure when porting a board to use driver model for PCI. Once the
> >> board is fully supported, this option should be disabled.
> >>
> >> +config PCI_PNP
> >> + bool "Enable Plug & Play support for PCI"
> >> + help
> >> + Enable PCI memory and I/O space resource allocation and assignment.
> >
> > This should be depends on PCI (if all of these options aren't already
> > hidden by that, that is) and default y, or default y if ...something.
> > Thanks!
>
> I see some of board configuration header file does not define PCI_PNP
> but defined PCI, so it is not a "default y if PCI". I will add a
> "depends on PCI || DM_PCI" in v2. Is that OK?
It's OK if some platforms that set PCI (or DM_PCI) don't enable PCI_PNP,
the aim here is to provide the reasonable default. ie for
DISPLAY_BOARDINFO/CPUINFO the default is y for ARM but there's a handful
of boards / SoCs that don't provide anything there. But that means we
have say 50 files setting it to off rather than 300 files setting it on.
So we should still default y this I bet and we'll have a much smaller
diffstat than in v1. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161014/40a006ba/attachment.sig>
next prev parent reply other threads:[~2016-10-14 13:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 5:04 [U-Boot] [PATCH] pci: Move CONFIG_PCI_PNP to Kconfig Bin Meng
2016-10-12 12:46 ` Tom Rini
2016-10-14 6:28 ` Bin Meng
2016-10-14 13:07 ` Tom Rini [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-10-17 6:35 Bin Meng
2016-10-17 11:50 ` Tom Rini
2016-10-25 1:08 ` Bin Meng
2016-10-25 1:09 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014130731.GJ31808@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox