From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Sat, 15 Oct 2016 13:48:03 -0400 Subject: [U-Boot] [PATCH] power: twl6030: fix code refactoring In-Reply-To: References: <1476355673-16018-1-git-send-email-nicolae.rosia.oss@gmail.com> <1476451705.806.30.camel@paulk.fr> Message-ID: <20161015174803.GM18591@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, Oct 15, 2016 at 08:41:35PM +0300, Nicolae Rosia wrote: > Hi, > > On Fri, Oct 14, 2016 at 4:28 PM, Paul Kocialkowski wrote: > > Le jeudi 13 octobre 2016 ? 13:47 +0300, Nicolae Rosia a ?crit : > >> From: Nicolae Rosia > >> > >> Commit a85362fb3e1fc7833723accddbbae431091d06b8 refactored the code > >> but the register read ended up in the wrong if branch. > >> Currently, the else branch checks a variable which is always 0. > > > > Good catch! Sorry for including that regression in the first place, I should > > have checked the patch more thoroughly. > No worries! > > > See comment below. > > The indentation before &value is inconsistent with what is done in the rest of > > the file. I think you should either just move the line as it was or only use one > > extra tab indent for the new line. Since this file breaks the 80 chars limit in > > a few places, I would tend to prefer the former. > > > checkpatch.pl was complaining, that's why I formatted it. > @Tom Rini, can you apply it either way? I'll take this and do you want to do a follow up to make the file checkpatch clean? Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: