From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common: env: add kconfig entry for env storage
Date: Mon, 17 Oct 2016 18:55:14 -0400 [thread overview]
Message-ID: <20161017225514.GW18591@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ0x17+VD-Lx1Hc_r8dFAsJtwbrSREoxeG3ge7Hp=+qncQ@mail.gmail.com>
On Mon, Oct 17, 2016 at 04:17:06PM -0600, Simon Glass wrote:
> Hi Peng,
>
> On 8 October 2016 at 03:06, Peng Fan <peng.fan@nxp.com> wrote:
> > Add Kconfig entry for ENV storage
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > Cc: Simon Glass <sjg@chromium.org>
> > Cc: Heiko Schocher <hs@denx.de>
> > Cc: Tom Rini <trini@konsulko.com>
> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> > Cc: Stefan Roese <sr@denx.de>
> > Cc: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
> > Cc: Francois Retief <fgretief@spaceteq.co.za>
> > ---
> > common/Kconfig | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 73 insertions(+)
> >
> > diff --git a/common/Kconfig b/common/Kconfig
> > index c69c141..a630924 100644
> > --- a/common/Kconfig
> > +++ b/common/Kconfig
> > @@ -158,6 +158,79 @@ config SPI_BOOT
> >
> > endmenu
> >
> > +menu "ENV storage media"
> > +
> > +config ENV_IS_IN_DATAFLASH
> > + bool "env stored in dataflash"
> > + help
> > + env stored in dataflash
>
> Can you add a little more help detail on this? Also I suspect we
> should have CONFIG_ENV as well, to enable the actual environment
> (independent of where it is stored).
Yes, please add a bit more to the text.
> Also, can you migrate the existing configs with moveconfig? That would
> be a big step forward and may inspire me to move it to linker lists.
Actually, I bet this is going to be messy enough that I'm fine running
the moveconfig myself right before I merge it in.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161017/92dc6a76/attachment.sig>
next prev parent reply other threads:[~2016-10-17 22:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-08 9:06 [U-Boot] [PATCH] common: env: add kconfig entry for env storage Peng Fan
2016-10-17 22:17 ` Simon Glass
2016-10-17 22:55 ` Tom Rini [this message]
2016-10-18 5:17 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017225514.GW18591@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox