[U-Boot] [PATCH v2 0/4] am57xx: Add fastboot support

[U-Boot] [PATCH v2 0/4] am57xx: Add fastboot support

[Sam Protsenko]

This patch series adds fastboot support for AM57x EVM boards.

As AM57x EVM USB controller index is 1 (as opposed to regular 0), some
changes had to be done to deal with this.

Changes in v2:
  - PATCH 2/4: Remove unnecessary check for CONFIG_FASTBOOT_USB_DEV in
    ti_omap5_common.h

Sam Protsenko (4):
  fastboot: Add CONFIG_FASTBOOT_USB_DEV option
  ti_omap5_common: Respect USB controller number in fastboot
  configs: am57xx: Enable download gadget
  configs: am57xx: Enable fastboot

 cmd/fastboot/Kconfig              |  8 ++++++++
 configs/am57xx_evm_defconfig      | 18 ++++++++++++++++++
 configs/am57xx_evm_nodt_defconfig | 18 ++++++++++++++++++
 configs/am57xx_hs_evm_defconfig   | 18 ++++++++++++++++++
 include/configs/ti_omap5_common.h |  3 ++-
 5 files changed, 64 insertions(+), 1 deletion(-)

-- 
2.9.3

[U-Boot] [PATCH v2 1/4] fastboot: Add CONFIG_FASTBOOT_USB_DEV option

[Sam Protsenko]

Some boards (like AM57x EVM) has USB OTG controller other than 0. So in
order to use correct controller number in compiled environment we should
define CONFIG_FASTBOOT_USB_DEV option.

For example, when doing "fastboot reboot-bootloader" we want to enter
fastboot mode automatically. But to do so we need to provide controller
number to "fastboot" command. If this procedure is defined in some config
which is common to bunch of boards, and boards have different USB
controller numbers, we can't just hardcode "fastboot 0" in the
environment. We need to use configurable option, which this patch adds.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
Changes in v2: None

 cmd/fastboot/Kconfig | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/cmd/fastboot/Kconfig b/cmd/fastboot/Kconfig
index 5d2facc..d555d0a 100644
--- a/cmd/fastboot/Kconfig
+++ b/cmd/fastboot/Kconfig
@@ -41,6 +41,14 @@ config FASTBOOT_BUF_SIZE
 	  downloads. This buffer should be as large as possible for a
 	  platform. Define this to the size available RAM for fastboot.
 
+config FASTBOOT_USB_DEV
+	int "USB controller number"
+	default 0
+	help
+	  Some boards have USB OTG controller other than 0. Define this
+	  option so it can be used in compiled environment (e.g. in
+	  CONFIG_BOOTCOMMAND).
+
 config FASTBOOT_FLASH
 	bool "Enable FASTBOOT FLASH command"
 	help
-- 
2.9.3

[U-Boot] [PATCH v2 1/4] fastboot: Add CONFIG_FASTBOOT_USB_DEV option

[Tom Rini]

On Mon, Oct 24, 2016 at 06:41:10PM +0300, Sam Protsenko wrote:

> Some boards (like AM57x EVM) has USB OTG controller other than 0. So in
> order to use correct controller number in compiled environment we should
> define CONFIG_FASTBOOT_USB_DEV option.
> 
> For example, when doing "fastboot reboot-bootloader" we want to enter
> fastboot mode automatically. But to do so we need to provide controller
> number to "fastboot" command. If this procedure is defined in some config
> which is common to bunch of boards, and boards have different USB
> controller numbers, we can't just hardcode "fastboot 0" in the
> environment. We need to use configurable option, which this patch adds.
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161024/b0a2c964/attachment.sig>

[U-Boot] [U-Boot, v2, 1/4] fastboot: Add CONFIG_FASTBOOT_USB_DEV option

[Tom Rini]

On Mon, Oct 24, 2016 at 06:41:10PM +0300, Semen Protsenko wrote:

> Some boards (like AM57x EVM) has USB OTG controller other than 0. So in
> order to use correct controller number in compiled environment we should
> define CONFIG_FASTBOOT_USB_DEV option.
> 
> For example, when doing "fastboot reboot-bootloader" we want to enter
> fastboot mode automatically. But to do so we need to provide controller
> number to "fastboot" command. If this procedure is defined in some config
> which is common to bunch of boards, and boards have different USB
> controller numbers, we can't just hardcode "fastboot 0" in the
> environment. We need to use configurable option, which this patch adds.
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161121/2100bf31/attachment.sig>

[U-Boot] [PATCH v2 2/4] ti_omap5_common: Respect USB controller number in fastboot

[Sam Protsenko]

On "fastboot reboot-bootloader" we check "dofastboot" variable and do
"fastboot 0" command in U-Boot if it's 1. But there are boards which have
USB controller number other than 0, so it should be respected when
performing "fastboot" command.

This patch reuses CONFIG_FASTBOOT_USB_DEV option toprovide correct USB
controller number to "fastboot" command.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
Changes in v2:
  - Remove unnecessary check for CONFIG_FASTBOOT_USB_DEV

 include/configs/ti_omap5_common.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/configs/ti_omap5_common.h b/include/configs/ti_omap5_common.h
index 29b7d96..b85fae3 100644
--- a/include/configs/ti_omap5_common.h
+++ b/include/configs/ti_omap5_common.h
@@ -114,7 +114,8 @@
 	"if test ${dofastboot} -eq 1; then " \
 		"echo Boot fastboot requested, resetting dofastboot ...;" \
 		"setenv dofastboot 0; saveenv;" \
-		"echo Booting into fastboot ...; fastboot 0;" \
+		"echo Booting into fastboot ...; " \
+		"fastboot " __stringify(CONFIG_FASTBOOT_USB_DEV) "; " \
 	"fi;" \
 	"run findfdt; " \
 	"run envboot; " \
-- 
2.9.3

[U-Boot] [PATCH v2 2/4] ti_omap5_common: Respect USB controller number in fastboot

[Tom Rini]

On Mon, Oct 24, 2016 at 06:41:11PM +0300, Sam Protsenko wrote:

> On "fastboot reboot-bootloader" we check "dofastboot" variable and do
> "fastboot 0" command in U-Boot if it's 1. But there are boards which have
> USB controller number other than 0, so it should be respected when
> performing "fastboot" command.
> 
> This patch reuses CONFIG_FASTBOOT_USB_DEV option toprovide correct USB
> controller number to "fastboot" command.
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161024/b03567ac/attachment.sig>

[U-Boot] [U-Boot, v2, 2/4] ti_omap5_common: Respect USB controller number in fastboot

[Tom Rini]

On Mon, Oct 24, 2016 at 06:41:11PM +0300, Semen Protsenko wrote:

> On "fastboot reboot-bootloader" we check "dofastboot" variable and do
> "fastboot 0" command in U-Boot if it's 1. But there are boards which have
> USB controller number other than 0, so it should be respected when
> performing "fastboot" command.
> 
> This patch reuses CONFIG_FASTBOOT_USB_DEV option toprovide correct USB
> controller number to "fastboot" command.
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161121/5f4ec7bd/attachment.sig>

[U-Boot] [PATCH v2 3/4] configs: am57xx: Enable download gadget

[Sam Protsenko]

Enable USB download gadget (needed for fastboot support) and all
dependencies.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
Changes in v2: None

 configs/am57xx_evm_defconfig      | 9 +++++++++
 configs/am57xx_evm_nodt_defconfig | 9 +++++++++
 configs/am57xx_hs_evm_defconfig   | 9 +++++++++
 3 files changed, 27 insertions(+)

diff --git a/configs/am57xx_evm_defconfig b/configs/am57xx_evm_defconfig
index 5acd4e7..89e927e 100644
--- a/configs/am57xx_evm_defconfig
+++ b/configs/am57xx_evm_defconfig
@@ -59,5 +59,14 @@ CONFIG_TI_QSPI=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_DWC3_GADGET=y
+CONFIG_USB_DWC3_OMAP=y
+CONFIG_USB_DWC3_PHY_OMAP=y
 CONFIG_USB_STORAGE=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_G_DNL_MANUFACTURER="Texas Instruments"
+CONFIG_G_DNL_VENDOR_NUM=0x0451
+CONFIG_G_DNL_PRODUCT_NUM=0xd022
 CONFIG_SPL_OF_LIBFDT=y
diff --git a/configs/am57xx_evm_nodt_defconfig b/configs/am57xx_evm_nodt_defconfig
index 9588a55..73e541d 100644
--- a/configs/am57xx_evm_nodt_defconfig
+++ b/configs/am57xx_evm_nodt_defconfig
@@ -36,5 +36,14 @@ CONFIG_TI_QSPI=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_DWC3_GADGET=y
+CONFIG_USB_DWC3_OMAP=y
+CONFIG_USB_DWC3_PHY_OMAP=y
 CONFIG_USB_STORAGE=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_G_DNL_MANUFACTURER="Texas Instruments"
+CONFIG_G_DNL_VENDOR_NUM=0x0451
+CONFIG_G_DNL_PRODUCT_NUM=0xd022
 CONFIG_OF_LIBFDT=y
diff --git a/configs/am57xx_hs_evm_defconfig b/configs/am57xx_hs_evm_defconfig
index a80e882..b25e21b 100644
--- a/configs/am57xx_hs_evm_defconfig
+++ b/configs/am57xx_hs_evm_defconfig
@@ -54,5 +54,14 @@ CONFIG_TI_QSPI=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_DWC3_GADGET=y
+CONFIG_USB_DWC3_OMAP=y
+CONFIG_USB_DWC3_PHY_OMAP=y
 CONFIG_USB_STORAGE=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_G_DNL_MANUFACTURER="Texas Instruments"
+CONFIG_G_DNL_VENDOR_NUM=0x0451
+CONFIG_G_DNL_PRODUCT_NUM=0xd022
 CONFIG_SPL_OF_LIBFDT=y
-- 
2.9.3

[U-Boot] [PATCH v2 3/4] configs: am57xx: Enable download gadget

[Tom Rini]

On Mon, Oct 24, 2016 at 06:41:12PM +0300, Sam Protsenko wrote:

> Enable USB download gadget (needed for fastboot support) and all
> dependencies.
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161024/e3872cbf/attachment.sig>

[U-Boot] [U-Boot, v2, 3/4] configs: am57xx: Enable download gadget

[Tom Rini]

On Mon, Oct 24, 2016 at 06:41:12PM +0300, Semen Protsenko wrote:

> Enable USB download gadget (needed for fastboot support) and all
> dependencies.
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161121/1c22ce1f/attachment.sig>

[U-Boot] [PATCH v2 4/4] configs: am57xx: Enable fastboot

[Sam Protsenko]

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
Changes in v2: None

 configs/am57xx_evm_defconfig      | 9 +++++++++
 configs/am57xx_evm_nodt_defconfig | 9 +++++++++
 configs/am57xx_hs_evm_defconfig   | 9 +++++++++
 3 files changed, 27 insertions(+)

diff --git a/configs/am57xx_evm_defconfig b/configs/am57xx_evm_defconfig
index 89e927e..888a2fd 100644
--- a/configs/am57xx_evm_defconfig
+++ b/configs/am57xx_evm_defconfig
@@ -16,6 +16,15 @@ CONFIG_SPL_STACK_R=y
 CONFIG_SPL_DMA_SUPPORT=y
 CONFIG_SPL_OS_BOOT=y
 CONFIG_HUSH_PARSER=y
+CONFIG_FASTBOOT=y
+CONFIG_USB_FUNCTION_FASTBOOT=y
+CONFIG_CMD_FASTBOOT=y
+CONFIG_ANDROID_BOOT_IMAGE=y
+CONFIG_FASTBOOT_BUF_ADDR=0x82000000
+CONFIG_FASTBOOT_BUF_SIZE=0x2f000000
+CONFIG_FASTBOOT_USB_DEV=1
+CONFIG_FASTBOOT_FLASH=y
+CONFIG_FASTBOOT_FLASH_MMC_DEV=1
 CONFIG_CMD_BOOTZ=y
 # CONFIG_CMD_IMLS is not set
 CONFIG_CMD_ASKENV=y
diff --git a/configs/am57xx_evm_nodt_defconfig b/configs/am57xx_evm_nodt_defconfig
index 73e541d..9da40bb 100644
--- a/configs/am57xx_evm_nodt_defconfig
+++ b/configs/am57xx_evm_nodt_defconfig
@@ -9,6 +9,15 @@ CONFIG_SPL=y
 CONFIG_SPL_DMA_SUPPORT=y
 CONFIG_SPL_OS_BOOT=y
 CONFIG_HUSH_PARSER=y
+CONFIG_FASTBOOT=y
+CONFIG_USB_FUNCTION_FASTBOOT=y
+CONFIG_CMD_FASTBOOT=y
+CONFIG_ANDROID_BOOT_IMAGE=y
+CONFIG_FASTBOOT_BUF_ADDR=0x82000000
+CONFIG_FASTBOOT_BUF_SIZE=0x2f000000
+CONFIG_FASTBOOT_USB_DEV=1
+CONFIG_FASTBOOT_FLASH=y
+CONFIG_FASTBOOT_FLASH_MMC_DEV=1
 CONFIG_CMD_BOOTZ=y
 # CONFIG_CMD_IMLS is not set
 CONFIG_CMD_ASKENV=y
diff --git a/configs/am57xx_hs_evm_defconfig b/configs/am57xx_hs_evm_defconfig
index b25e21b..e27b214 100644
--- a/configs/am57xx_hs_evm_defconfig
+++ b/configs/am57xx_hs_evm_defconfig
@@ -17,6 +17,15 @@ CONFIG_SPL=y
 CONFIG_SPL_STACK_R=y
 CONFIG_SPL_DMA_SUPPORT=y
 CONFIG_HUSH_PARSER=y
+CONFIG_FASTBOOT=y
+CONFIG_USB_FUNCTION_FASTBOOT=y
+CONFIG_CMD_FASTBOOT=y
+CONFIG_ANDROID_BOOT_IMAGE=y
+CONFIG_FASTBOOT_BUF_ADDR=0x82000000
+CONFIG_FASTBOOT_BUF_SIZE=0x2f000000
+CONFIG_FASTBOOT_USB_DEV=1
+CONFIG_FASTBOOT_FLASH=y
+CONFIG_FASTBOOT_FLASH_MMC_DEV=1
 CONFIG_CMD_BOOTZ=y
 # CONFIG_CMD_IMLS is not set
 CONFIG_CMD_ASKENV=y
-- 
2.9.3

[U-Boot] [PATCH v2 4/4] configs: am57xx: Enable fastboot

[Tom Rini]

On Mon, Oct 24, 2016 at 06:41:13PM +0300, Sam Protsenko wrote:

> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161024/906ff366/attachment.sig>

[U-Boot] [PATCH v2 4/4] configs: am57xx: Enable fastboot

[Sam Protsenko]

On Mon, Oct 24, 2016 at 7:12 PM, Tom Rini <trini@konsulko.com> wrote:
> On Mon, Oct 24, 2016 at 06:41:13PM +0300, Sam Protsenko wrote:
>
>> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> --
> Tom

Bump. Please review and apply this series. Thanks.

[U-Boot] [U-Boot,v2,4/4] configs: am57xx: Enable fastboot

[Tom Rini]

On Mon, Oct 24, 2016 at 06:41:13PM +0300, Semen Protsenko wrote:

> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161121/e9d658c4/attachment.sig>