From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] drivers/pci/Kconfig: Add PCI
Date: Wed, 26 Oct 2016 13:22:15 -0400 [thread overview]
Message-ID: <20161026172215.GT18591@bill-the-cat> (raw)
In-Reply-To: <79498518-d9e5-2e52-3f7b-4d26803fe346@wwwdotorg.org>
On Wed, Oct 26, 2016 at 11:11:31AM -0600, Stephen Warren wrote:
> On 10/24/2016 02:13 PM, Tom Rini wrote:
> >Add 'PCI' as a menu option and migrate all existing users.
> >
> >Signed-off-by: Tom Rini <trini@konsulko.com>
> >---
> >Tegra is in a funny spot here. TEGRA_COMMON will select DM_PCI and
> >DM_PCICOMPAT. But adding PCI to the list here results in the following:
> > aarch64: (for 61/61 boards) all +217.7 data +24.8 rodata +47.9 text +145.0
> > p2571 : all +4426 data +504 rodata +974 text +2948
> > e2220-1170 : all +4426 data +504 rodata +974 text +2948
> > p2371-0000 : all +4426 data +504 rodata +974 text +2948
> > arm: (for 557/557 boards) all +96.9 bss +0.1 data +7.2 rodata +23.7 spl/u-boot-spl:all +0.1 spl/u-boot-spl:rodata +0.1 spl/u-boot-spl:text +0.0 text +65.9
> > whistler : all +3914 bss +28 data +288 rodata +934 spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2664
> > paz00 : all +3908 bss +16 data +280 rodata +952 text +2660
> > colibri_t30 : all +3898 bss +12 data +280 rodata +934 spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2672
> > venice2 : all +3862 bss +28 data +288 rodata +934 spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
> > plutux : all +3850 bss +32 data +280 rodata +934 spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2604
> > nyan-big : all +3852 bss -4 data +296 rodata +952 text +2608
> > dalmore : all +3846 bss +12 data +288 rodata +934 spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
> > seaboard : all +3848 bss +8 data +288 rodata +952 text +2600
> > medcom-wide : all +3848 bss +16 data +280 rodata +952 text +2600
> > harmony : all +3848 bss +8 data +288 rodata +952 text +2600
> > tec-ng : all +3842 bss +8 data +288 rodata +934 spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
> > ventana : all +3844 bss -48 data +280 rodata +952 text +2660
> > colibri_t20 : all +3836 bss -4 data +288 rodata +952 text +2600
> > tec : all +3784 bss -48 data +280 rodata +952 text +2600
> >
> >Because prior to this patch they did not set PCI and thus what code was
> >build here was largely discarded at link time. One or two of the above
> >look to fall in to the case where PCI_TEGRA should be off, but not all.
> >What should we do about this?
>
> >diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
>
> >@@ -38,6 +38,7 @@ config TEGRA_COMMON
> > select DM_SPI_FLASH
> > select MISC
> > select OF_CONTROL
> >+ select PCI
>
> I don't think this is correct; only a few Tegra boards have PCI, so
> we should likely enabling CONFIG_PCI from the relevant board
> defconfigs, or select it only if the Tegra PCI controller option is
> selected.
>
> The list of Tegra boards that support PCI is:
>
> harmony
> trimslice
> apalis
> beaver
> cardhu
> cei-tk1-som
> jetson-tk1
> p2371-2180
> p2771-0000-000
> p2771-0000-500
OK. I think then the issue is that
arch/arm/mach-tegra/Kconfig::TEGRA_COMMON should not be select'ing
DM_PCI to start with and those handful of boards should be enabling all
relevant PCI options. I'll re-work things and re-confirm that then
there are no size changes. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161026/745f4faf/attachment.sig>
next prev parent reply other threads:[~2016-10-26 17:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 20:13 [U-Boot] [PATCH] drivers/pci/Kconfig: Add PCI Tom Rini
2016-10-26 16:31 ` Simon Glass
2016-10-26 17:11 ` Stephen Warren
2016-10-26 17:22 ` Tom Rini [this message]
2016-10-26 20:59 ` Tom Rini
2016-10-26 21:15 ` [U-Boot] [PATCH v2] " Tom Rini
2016-10-26 21:23 ` Stephen Warren
2016-10-28 13:07 ` [U-Boot] [U-Boot,v2] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026172215.GT18591@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox