From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 08/10] sun5/7i: add an implementation of the psci suspend function
Date: Thu, 27 Oct 2016 15:20:02 +0200 [thread overview]
Message-ID: <20161027132002.djtwg3bzulcefbrv@lukather> (raw)
In-Reply-To: <20161027131058.2kqfututcqwkjgsr@kwain>
Hi,
On Thu, Oct 27, 2016 at 03:10:58PM +0200, Antoine Tenart wrote:
> Hi,
>
> On Wed, Oct 26, 2016 at 02:38:10PM +0200, Maxime Ripard wrote:
> > On Wed, Oct 26, 2016 at 02:10:31PM +0200, Antoine Tenart wrote:
> > > +
> > > +#ifndef CONFIG_MACH_SUN7I
> > > + /* switch cpuclk to losc */
> > > + clrbits_le32(&ccm->cpu_ahb_apb0_cfg, 0x3 << CPU_CLK_SRC_SHIFT);
> > > +#endif
> >
> > Some kind of comment here would be nice.
>
> That's based on my experiments, switching the cpu clk to losc wasn't
> working (the board hanged). I agree that's not the best explanation
> ever...
Still, even if that's only to say that it was based on experiments and
you don't really know why. It's definitely not obvious to anyone, so
it deserves a comment to explain why you did it that way.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161027/1c135fb1/attachment.sig>
next prev parent reply other threads:[~2016-10-27 13:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 12:10 [U-Boot] [PATCH v3 00/10] sunxi: sun5/7i: add the psci suspend function Antoine Tenart
2016-10-26 12:10 ` [U-Boot] [PATCH v3 01/10] arm: add atomic functions with return support Antoine Tenart
2016-10-26 15:14 ` Mark Rutland
2016-10-27 13:28 ` Antoine Tenart
2016-10-26 12:10 ` [U-Boot] [PATCH v3 02/10] ARM: add the ARM_GIC configuration option Antoine Tenart
2016-10-26 12:10 ` [U-Boot] [PATCH v3 03/10] sunxi: select ARM_GIC for sun[6789]i Antoine Tenart
2016-10-26 12:10 ` [U-Boot] [PATCH v3 04/10] ARM: select ARM_GIC for SoCs having a psci implementation Antoine Tenart
2016-10-26 12:10 ` [U-Boot] [PATCH v3 05/10] exynos: select ARM_GIC for TARGET_ARNDALE Antoine Tenart
2016-10-26 12:10 ` [U-Boot] [PATCH v3 06/10] tegra: select ARM_GIC for Tegra TK1s Antoine Tenart
2016-10-26 14:55 ` Stephen Warren
2016-10-26 14:59 ` Antoine Tenart
2016-10-26 15:01 ` Stephen Warren
2016-10-27 13:13 ` Antoine Tenart
2016-10-26 12:10 ` [U-Boot] [PATCH v3 07/10] ARM: PSCI: protect GIC specific code with ARM_GIC Antoine Tenart
2016-10-26 12:10 ` [U-Boot] [PATCH v3 08/10] sun5/7i: add an implementation of the psci suspend function Antoine Tenart
2016-10-26 12:38 ` Maxime Ripard
2016-10-27 13:10 ` Antoine Tenart
2016-10-27 13:20 ` Maxime Ripard [this message]
2016-10-27 13:32 ` Antoine Tenart
2016-10-27 13:21 ` Chen-Yu Tsai
2016-10-27 13:41 ` Antoine Tenart
2016-10-27 13:56 ` Chen-Yu Tsai
2016-10-26 12:10 ` [U-Boot] [PATCH v3 09/10] sun5i: add defines used by the PSCI code Antoine Tenart
2016-10-26 12:34 ` Maxime Ripard
2016-10-27 13:04 ` Antoine Tenart
2016-10-26 12:10 ` [U-Boot] [PATCH v3 10/10] sun5i: boot in non-secure mode by default Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027132002.djtwg3bzulcefbrv@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox