From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antoine Tenart Date: Thu, 27 Oct 2016 15:32:37 +0200 Subject: [U-Boot] [PATCH v3 08/10] sun5/7i: add an implementation of the psci suspend function In-Reply-To: <20161027132002.djtwg3bzulcefbrv@lukather> References: <20161026121033.6339-1-antoine.tenart@free-electrons.com> <20161026121033.6339-9-antoine.tenart@free-electrons.com> <20161026123810.b4ilk3wkz7nxjscy@lukather> <20161027131058.2kqfututcqwkjgsr@kwain> <20161027132002.djtwg3bzulcefbrv@lukather> Message-ID: <20161027133237.htcr7ujb2xtjcrzz@kwain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Oct 27, 2016 at 03:20:02PM +0200, Maxime Ripard wrote: > On Thu, Oct 27, 2016 at 03:10:58PM +0200, Antoine Tenart wrote: > > On Wed, Oct 26, 2016 at 02:38:10PM +0200, Maxime Ripard wrote: > > > On Wed, Oct 26, 2016 at 02:10:31PM +0200, Antoine Tenart wrote: > > > > + > > > > +#ifndef CONFIG_MACH_SUN7I > > > > + /* switch cpuclk to losc */ > > > > + clrbits_le32(&ccm->cpu_ahb_apb0_cfg, 0x3 << CPU_CLK_SRC_SHIFT); > > > > +#endif > > > > > > Some kind of comment here would be nice. > > > > That's based on my experiments, switching the cpu clk to losc wasn't > > working (the board hanged). I agree that's not the best explanation > > ever... > > Still, even if that's only to say that it was based on experiments and > you don't really know why. It's definitely not obvious to anyone, so > it deserves a comment to explain why you did it that way. Sure, I wasn't arguing about the need of a comment :) Antoine -- Antoine T?nart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: