From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] armv8: define get_ticks() for the ARMv8 Generic Timer
Date: Sun, 6 Nov 2016 20:14:22 -0500 [thread overview]
Message-ID: <20161107011422.GI20830@bill-the-cat> (raw)
In-Reply-To: <1478134585-454-1-git-send-email-andre.przywara@arm.com>
On Thu, Nov 03, 2016 at 12:56:25AM +0000, Andre Przywara wrote:
> For 64-bit ARM systems we provide just a timer_read_counter()
> implementation and rely on the generic non-uclass get_ticks() function
> in lib/time.c to call the former.
> However this function is actually not 64-bit safe, as it assumes a
> "long" to be 32-bit. Beside the fact that the resulting uint64_t
> isn't bigger than "long" on 64-bit architectures and thus combining two
> counters makes no sense, we get all kind of weird results when we try
> to OR in the high value shifted by _32_ bits.
> So let's avoid that function at all and provide a straight forward
> get_ticks() implementation for ARMv8, which also is in line with ARMv7.
>
> This fixes occasional immediate time-out expiration issues I see on the
> Pine64 board. The root cause of this needs to be investigated, but this
> fix looks like the right thing anyway.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161106/a06bc697/attachment.sig>
prev parent reply other threads:[~2016-11-07 1:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 0:56 [U-Boot] [PATCH] armv8: define get_ticks() for the ARMv8 Generic Timer Andre Przywara
2016-11-07 1:14 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107011422.GI20830@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox