public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] buildman: Fix building based on 'options' field
@ 2016-11-05  2:59 Tom Rini
  2016-11-05 16:09 ` Simon Glass
  2016-11-07  1:17 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Tom Rini @ 2016-11-05  2:59 UTC (permalink / raw)
  To: u-boot

The README for buildman says that we can use any field in boards.cfg to
decide what to build.  However, we were not saving the options field
correctly.

Cc: Simon Glass <sjg@chromium.org>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
 tools/buildman/board.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/buildman/board.py b/tools/buildman/board.py
index 5d536d5f2004..ae0e0b8e1719 100644
--- a/tools/buildman/board.py
+++ b/tools/buildman/board.py
@@ -92,9 +92,9 @@ class Board:
         self.board_name = board_name
         self.vendor = vendor
         self.soc = soc
-        self.props = [self.target, self.arch, self.cpu, self.board_name,
-                      self.vendor, self.soc]
         self.options = options
+        self.props = [self.target, self.arch, self.cpu, self.board_name,
+                      self.vendor, self.soc, self.options]
         self.build_it = False
 
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] buildman: Fix building based on 'options' field
  2016-11-05  2:59 [U-Boot] [PATCH] buildman: Fix building based on 'options' field Tom Rini
@ 2016-11-05 16:09 ` Simon Glass
  2016-11-07  1:17 ` [U-Boot] " Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2016-11-05 16:09 UTC (permalink / raw)
  To: u-boot

On 4 November 2016 at 20:59, Tom Rini <trini@konsulko.com> wrote:
> The README for buildman says that we can use any field in boards.cfg to
> decide what to build.  However, we were not saving the options field
> correctly.
>
> Cc: Simon Glass <sjg@chromium.org>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>  tools/buildman/board.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] buildman: Fix building based on 'options' field
  2016-11-05  2:59 [U-Boot] [PATCH] buildman: Fix building based on 'options' field Tom Rini
  2016-11-05 16:09 ` Simon Glass
@ 2016-11-07  1:17 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-11-07  1:17 UTC (permalink / raw)
  To: u-boot

On Fri, Nov 04, 2016 at 10:59:45PM -0400, Tom Rini wrote:

> The README for buildman says that we can use any field in boards.cfg to
> decide what to build.  However, we were not saving the options field
> correctly.
> 
> Cc: Simon Glass <sjg@chromium.org>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161106/39ed120f/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-11-07  1:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-05  2:59 [U-Boot] [PATCH] buildman: Fix building based on 'options' field Tom Rini
2016-11-05 16:09 ` Simon Glass
2016-11-07  1:17 ` [U-Boot] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox