From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/7] tools: sunxi: Add spl image builder
Date: Fri, 11 Nov 2016 11:20:47 -0500 [thread overview]
Message-ID: <20161111162047.GI27304@bill-the-cat> (raw)
In-Reply-To: <312ad66b8bd78b877f82ebd2fb16efcbb51e0a15.1478621974.git-series.maxime.ripard@free-electrons.com>
On Tue, Nov 08, 2016 at 05:21:14PM +0100, Maxime Ripard wrote:
> This program generates raw SPL images that can be flashed on the NAND with
> the ECC and randomizer properly set up.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
[snip]
> +++ b/tools/sunxi-spl-image-builder.c
> @@ -0,0 +1,1113 @@
> +/*
> + * Generic binary BCH encoding/decoding library
OK, but this is also lib/bch.c and re-using lib/ code for tools is a
normal best practice. I'd suggest re-factoring this code in sunxi-tools
sot that it too borrows lib/bch.c from the kernel (and can re-sync
bugfixes if needed). Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161111/2ff002af/attachment.sig>
next prev parent reply other threads:[~2016-11-11 16:20 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 16:21 [U-Boot] [PATCH 0/7] sunxi: Add support for the CHIP Pro Maxime Ripard
2016-11-08 16:21 ` [U-Boot] [PATCH 1/7] sunxi: Sync GR8 DTS and AXP209 with the kernel Maxime Ripard
2016-11-14 11:15 ` Hans de Goede
2016-11-08 16:21 ` [U-Boot] [PATCH 2/7] mtd: nand: add support for the TC58NVG2S0H chip Maxime Ripard
2016-11-14 11:15 ` Hans de Goede
2016-11-15 5:04 ` Scott Wood
2016-11-08 16:21 ` [U-Boot] [PATCH 3/7] sunxi: Enable UBI and NAND support Maxime Ripard
2016-11-08 16:27 ` Boris Brezillon
2016-11-08 16:27 ` Boris Brezillon
2016-11-09 14:32 ` Maxime Ripard
2016-11-09 14:57 ` Boris Brezillon
2016-11-14 11:18 ` Hans de Goede
2016-11-14 14:09 ` Maxime Ripard
2016-11-14 14:12 ` Hans de Goede
2016-11-14 14:12 ` Maxime Ripard
2016-11-14 14:21 ` Hans de Goede
2016-11-14 17:03 ` Tom Rini
2016-11-17 22:27 ` Maxime Ripard
2016-11-08 16:21 ` [U-Boot] [PATCH 4/7] tools: sunxi: Add spl image builder Maxime Ripard
2016-11-08 16:29 ` Boris Brezillon
2016-11-08 20:45 ` Maxime Ripard
2016-11-11 16:20 ` Tom Rini [this message]
2016-11-14 15:20 ` Maxime Ripard
2016-11-14 15:25 ` Tom Rini
2016-11-14 18:58 ` Maxime Ripard
2016-11-14 18:59 ` Tom Rini
2016-11-14 11:18 ` Hans de Goede
2016-11-14 11:29 ` Hans de Goede
2016-11-14 13:53 ` Maxime Ripard
2016-11-14 14:01 ` Hans de Goede
2016-11-08 16:21 ` [U-Boot] [PATCH 5/7] nand: sunxi: Add options for the SPL NAND configuration Maxime Ripard
2016-11-08 16:31 ` Boris Brezillon
2016-11-14 11:19 ` Hans de Goede
2016-11-15 5:07 ` Scott Wood
2016-11-08 16:21 ` [U-Boot] [PATCH 6/7] scripts: sunxi: Build an raw SPL image Maxime Ripard
2016-11-08 16:33 ` Boris Brezillon
2016-11-14 11:19 ` Hans de Goede
2016-11-14 11:30 ` Hans de Goede
2016-11-08 16:21 ` [U-Boot] [PATCH 7/7] sunxi: Add support for the CHIP Pro Maxime Ripard
2016-11-14 11:20 ` Hans de Goede
2016-11-09 7:47 ` [U-Boot] [PATCH 0/7] " Heiko Schocher
2016-11-09 14:44 ` Maxime Ripard
2016-11-10 11:57 ` Heiko Schocher
2016-11-11 16:24 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161111162047.GI27304@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox