* [U-Boot] [U-BOOT][TEST PATCH 1/5] Cosmetic api: api_storage.c Align parenthesis
2016-11-23 6:26 [U-Boot] [U-BOOT][TEST PATCH 0/5] Cosmetic modifications api_storage.c Walt Feasel
@ 2016-11-23 6:26 ` Walt Feasel
2016-12-04 23:14 ` [U-Boot] [U-Boot, U-BOOT, TEST, " Tom Rini
2016-11-23 6:26 ` [U-Boot] [U-BOOT][TEST PATCH 2/5] Cosmetic api: api_storage.c Blank line after { Walt Feasel
` (4 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Walt Feasel @ 2016-11-23 6:26 UTC (permalink / raw)
To: u-boot
Make checkpatch style modification for
CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
---
This patch series is to verify a correct patch submission.
Please let me know if there is a problem or preferred
wording for submitting cosmetic patches.
api/api_storage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/api/api_storage.c b/api/api_storage.c
index d4c0d5f..ea44d97 100644
--- a/api/api_storage.c
+++ b/api/api_storage.c
@@ -282,7 +282,7 @@ static int dev_enum_stor(int type, struct device_info *di)
if (found)
debugf("device found, returning cookie 0x%08x\n",
- (u_int32_t)di->cookie);
+ (u_int32_t)di->cookie);
else
debugf("no device found\n");
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [U-Boot] [U-BOOT][TEST PATCH 2/5] Cosmetic api: api_storage.c Blank line after {
2016-11-23 6:26 [U-Boot] [U-BOOT][TEST PATCH 0/5] Cosmetic modifications api_storage.c Walt Feasel
2016-11-23 6:26 ` [U-Boot] [U-BOOT][TEST PATCH 1/5] Cosmetic api: api_storage.c Align parenthesis Walt Feasel
@ 2016-11-23 6:26 ` Walt Feasel
2016-12-04 23:15 ` [U-Boot] [U-Boot, U-BOOT, TEST, " Tom Rini
2016-11-23 6:26 ` [U-Boot] [U-BOOT][TEST PATCH 3/5] Cosmetic api: api_storage.c Line over 80 char Walt Feasel
` (3 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Walt Feasel @ 2016-11-23 6:26 UTC (permalink / raw)
To: u-boot
Make checkpatch style modification for
CHECK: Blank lines aren't necessary after
an open brace '{'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
---
This patch series is to verify a correct patch submission.
Please let me know if there is a problem or preferred
wording for submitting cosmetic patches.
api/api_storage.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/api/api_storage.c b/api/api_storage.c
index ea44d97..9c4ff5b 100644
--- a/api/api_storage.c
+++ b/api/api_storage.c
@@ -220,7 +220,6 @@ static int dev_enum_stor(int type, struct device_info *di)
*/
if (di->cookie == NULL) {
-
debugf("group%d - enum restart\n", type);
/*
@@ -231,7 +230,6 @@ static int dev_enum_stor(int type, struct device_info *di)
specs[type].enum_started = 1;
} else if (dev_is_stor(type, di)) {
-
debugf("group%d - enum continued for the next device\n", type);
if (specs[type].enum_ended) {
@@ -243,7 +241,6 @@ static int dev_enum_stor(int type, struct device_info *di)
found = dev_stor_get(type, 0, &more, di);
} else {
-
if (specs[type].enum_ended) {
debugf("group %d - already enumerated, skipping\n", type);
return 0;
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [U-Boot] [U-BOOT][TEST PATCH 3/5] Cosmetic api: api_storage.c Line over 80 char
2016-11-23 6:26 [U-Boot] [U-BOOT][TEST PATCH 0/5] Cosmetic modifications api_storage.c Walt Feasel
2016-11-23 6:26 ` [U-Boot] [U-BOOT][TEST PATCH 1/5] Cosmetic api: api_storage.c Align parenthesis Walt Feasel
2016-11-23 6:26 ` [U-Boot] [U-BOOT][TEST PATCH 2/5] Cosmetic api: api_storage.c Blank line after { Walt Feasel
@ 2016-11-23 6:26 ` Walt Feasel
2016-12-04 23:15 ` [U-Boot] [U-Boot, U-BOOT, TEST, " Tom Rini
2016-11-23 6:26 ` [U-Boot] [U-BOOT][TEST PATCH 4/5] Cosmetic api: api_storage.c Comment style Walt Feasel
` (2 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Walt Feasel @ 2016-11-23 6:26 UTC (permalink / raw)
To: u-boot
Make checkpatch style modification for
WARNING: line over 80 characters
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
---
This patch series is to verify a correct patch submission.
Please let me know if there is a problem or preferred
wording for submitting cosmetic patches.
api/api_storage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/api/api_storage.c b/api/api_storage.c
index 9c4ff5b..3db0979 100644
--- a/api/api_storage.c
+++ b/api/api_storage.c
@@ -37,7 +37,7 @@ struct stor_spec {
int max_dev;
int enum_started;
int enum_ended;
- int type; /* "external" type: DT_STOR_{IDE,USB,etc} */
+ int type; /* "external" type: DT_STOR_{IDE,USB,etc} */
char *name;
};
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [U-Boot] [U-BOOT][TEST PATCH 4/5] Cosmetic api: api_storage.c Comment style
2016-11-23 6:26 [U-Boot] [U-BOOT][TEST PATCH 0/5] Cosmetic modifications api_storage.c Walt Feasel
` (2 preceding siblings ...)
2016-11-23 6:26 ` [U-Boot] [U-BOOT][TEST PATCH 3/5] Cosmetic api: api_storage.c Line over 80 char Walt Feasel
@ 2016-11-23 6:26 ` Walt Feasel
2016-12-04 23:16 ` [U-Boot] [U-Boot, U-BOOT, TEST, " Tom Rini
2016-11-23 6:26 ` [U-Boot] [U-BOOT][TEST PATCH 5/5] Cosmetic api: api_storage.c Spelling correction Walt Feasel
2016-11-23 14:03 ` [U-Boot] [U-BOOT][TEST PATCH 0/5] Cosmetic modifications api_storage.c Walt Feasel
5 siblings, 1 reply; 12+ messages in thread
From: Walt Feasel @ 2016-11-23 6:26 UTC (permalink / raw)
To: u-boot
Make comment style modifications
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
---
This patch series is to verify a correct patch submission.
Please let me know if there is a problem or preferred
wording for submitting cosmetic patches.
api/api_storage.c | 33 ++++++++++++++++++---------------
1 file changed, 18 insertions(+), 15 deletions(-)
diff --git a/api/api_storage.c b/api/api_storage.c
index 3db0979..c51ab30 100644
--- a/api/api_storage.c
+++ b/api/api_storage.c
@@ -116,8 +116,10 @@ static int dev_stor_get(int type, int first, int *more, struct device_info *di)
else
found = 1;
- /* provide hint if there are more devices in
- * this group to enumerate */
+ /*
+ * provide hint if there are more devices in
+ * this group to enumerate
+ */
if (1 < specs[type].max_dev)
*more = 1;
@@ -125,8 +127,10 @@ static int dev_stor_get(int type, int first, int *more, struct device_info *di)
for (i = 0; i < specs[type].max_dev; i++)
if (di->cookie ==
(void *)blk_get_dev(specs[type].name, i)) {
- /* previous cookie found -- advance to the
- * next device, if possible */
+ /*
+ * previous cookie found -- advance to the
+ * next device, if possible
+ */
if (++i >= specs[type].max_dev) {
/* out of range, no more to enum */
@@ -141,8 +145,10 @@ static int dev_stor_get(int type, int first, int *more, struct device_info *di)
else
found = 1;
- /* provide hint if there are more devices in
- * this group to enumerate */
+ /*
+ * provide hint if there are more devices in
+ * this group to enumerate
+ */
if ((i + 1) < specs[type].max_dev)
*more = 1;
@@ -171,9 +177,8 @@ static int dev_stor_get(int type, int first, int *more, struct device_info *di)
}
-/*
- * returns: ENUM_IDE, ENUM_USB etc. based on struct blk_desc
- */
+/* returns: ENUM_IDE, ENUM_USB etc. based on struct blk_desc */
+
static int dev_stor_type(struct blk_desc *dd)
{
int i, j;
@@ -187,9 +192,8 @@ static int dev_stor_type(struct blk_desc *dd)
}
-/*
- * returns: 0/1 whether cookie points to some device in this group
- */
+/* returns: 0/1 whether cookie points to some device in this group */
+
static int dev_is_stor(int type, struct device_info *di)
{
return (dev_stor_type(di->cookie) == type) ? 1 : 0;
@@ -300,9 +304,8 @@ int dev_enum_storage(struct device_info *di)
{
int i;
- /*
- * check: ide, usb, scsi, mmc
- */
+ /* check: ide, usb, scsi, mmc */
+
for (i = ENUM_IDE; i < ENUM_MAX; i++) {
if (dev_enum_stor(i, di))
return 1;
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [U-Boot] [U-BOOT][TEST PATCH 5/5] Cosmetic api: api_storage.c Spelling correction
2016-11-23 6:26 [U-Boot] [U-BOOT][TEST PATCH 0/5] Cosmetic modifications api_storage.c Walt Feasel
` (3 preceding siblings ...)
2016-11-23 6:26 ` [U-Boot] [U-BOOT][TEST PATCH 4/5] Cosmetic api: api_storage.c Comment style Walt Feasel
@ 2016-11-23 6:26 ` Walt Feasel
2016-12-04 23:16 ` [U-Boot] [U-Boot, U-BOOT, TEST, " Tom Rini
2016-11-23 14:03 ` [U-Boot] [U-BOOT][TEST PATCH 0/5] Cosmetic modifications api_storage.c Walt Feasel
5 siblings, 1 reply; 12+ messages in thread
From: Walt Feasel @ 2016-11-23 6:26 UTC (permalink / raw)
To: u-boot
Make spelling correction for 'from'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
---
This patch series is to verify a correct patch submission.
Please let me know if there is a problem or preferred
wording for submitting cosmetic patches.
api/api_storage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/api/api_storage.c b/api/api_storage.c
index c51ab30..fdb8c78 100644
--- a/api/api_storage.c
+++ b/api/api_storage.c
@@ -256,7 +256,7 @@ static int dev_enum_stor(int type, struct device_info *di)
/*
* 2b. If enumerating devices in this group did not
* happen before, it means the cookie pointed to a
- * device frome some other group (another storage
+ * device from some other group (another storage
* group, or network); in this case try to take the
* first available device from our group
*/
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [U-Boot] [U-BOOT][TEST PATCH 0/5] Cosmetic modifications api_storage.c
2016-11-23 6:26 [U-Boot] [U-BOOT][TEST PATCH 0/5] Cosmetic modifications api_storage.c Walt Feasel
` (4 preceding siblings ...)
2016-11-23 6:26 ` [U-Boot] [U-BOOT][TEST PATCH 5/5] Cosmetic api: api_storage.c Spelling correction Walt Feasel
@ 2016-11-23 14:03 ` Walt Feasel
5 siblings, 0 replies; 12+ messages in thread
From: Walt Feasel @ 2016-11-23 14:03 UTC (permalink / raw)
To: u-boot
Looks like [U-boot] is added at the mailing list server.
I had added it since it was not included to my 1st test
email to myself.
I have fixed that.
^ permalink raw reply [flat|nested] 12+ messages in thread