public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: move CONFIG_SATAPWR to Kconfig option
Date: Thu, 24 Nov 2016 22:22:16 +0100	[thread overview]
Message-ID: <20161124212216.fkdsx44s3gdbtil4@lukather> (raw)
In-Reply-To: <20161123182816.14051-1-jelle@vdwaa.nl>

On Wed, Nov 23, 2016 at 07:28:16PM +0100, Jelle van der Waa wrote:
> Introduce a new CONFIG_SATAPWR Kconfig option to replace the
> option in CONFIG_SYS_EXTRA_OPTIONS.
> 
> Signed-off-by: Jelle van der Waa <jelle@vdwaa.nl>
> ---
>  board/sunxi/Kconfig                        |  7 +++++++
>  board/sunxi/board.c                        | 11 ++++++-----
>  configs/A10-OLinuXino-Lime_defconfig       |  3 ++-
>  configs/A20-OLinuXino-Lime2_defconfig      |  3 ++-
>  configs/A20-OLinuXino-Lime_defconfig       |  3 ++-
>  configs/A20-OLinuXino_MICRO_defconfig      |  3 ++-
>  configs/A20-Olimex-SOM-EVB_defconfig       |  3 ++-
>  configs/Cubieboard2_defconfig              |  3 ++-
>  configs/Cubieboard_defconfig               |  3 ++-
>  configs/Cubietruck_defconfig               |  3 ++-
>  configs/Itead_Ibox_A20_defconfig           |  3 ++-
>  configs/Lamobo_R1_defconfig                |  3 ++-
>  configs/Linksprite_pcDuino3_Nano_defconfig |  3 ++-
>  configs/Linksprite_pcDuino3_defconfig      |  3 ++-
>  configs/Sinovoip_BPI_M3_defconfig          |  2 +-
>  configs/orangepi_plus_defconfig            |  3 ++-
>  16 files changed, 40 insertions(+), 19 deletions(-)
> 
> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
> index ae2fba1..fe2f7b4 100644
> --- a/board/sunxi/Kconfig
> +++ b/board/sunxi/Kconfig
> @@ -667,6 +667,13 @@ config GMAC_TX_DELAY
>  	---help---
>  	Set the GMAC Transmit Clock Delay Chain value.
>  
> +config SATAPWR
> +	string "power pin for SATA"
> +	default ""
> +	---help---
> +	Set the power pin for SATA. This takes a string in the format
> +	understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
> +

This looks like a rather generic option. Can't this be in
drivers/block instead?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161124/238ed8cd/attachment.sig>

  reply	other threads:[~2016-11-24 21:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23 18:28 [U-Boot] [PATCH] sunxi: move CONFIG_SATAPWR to Kconfig option Jelle van der Waa
2016-11-24 21:22 ` Maxime Ripard [this message]
2016-11-25  8:12   ` Hans de Goede
2016-11-28 12:42     ` Maxime Ripard
2016-11-28 13:20       ` Hans de Goede
2016-11-29 20:39         ` Maxime Ripard
2016-11-29 21:11           ` Tom Rini
2016-11-29 21:17             ` Maxime Ripard
2016-11-29 22:25               ` Tom Rini
2016-12-05 20:43                 ` Jelle van der Waa
2016-12-09  7:28                   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161124212216.fkdsx44s3gdbtil4@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox