From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 3/8] spl: Move the loading code into its own function
Date: Mon, 28 Nov 2016 15:09:42 -0500 [thread overview]
Message-ID: <20161128200942.GP2546@bill-the-cat> (raw)
In-Reply-To: <1479403775-6062-4-git-send-email-sjg@chromium.org>
On Thu, Nov 17, 2016 at 10:29:30AM -0700, Simon Glass wrote:
> Create a boot_from_devices() function to handle trying each device. This
> helps to reduce the size of the already-large board_init_r() function.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
So with gcc-5.x and later:
+In file included from include/common.h:27:0, + from common/spl/spl.c:9: + #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
+ ^
+common/spl/spl.c:384:18: note: in expansion of macro 'ARRAY_SIZE'
+ for (i = 0; i < ARRAY_SIZE(spl_boot_list) &&
+ ^
+common/spl/spl.c:380:13: note: declared here
+ u32 spl_boot_list[])
+ ^
w+common/spl/spl.c: In function 'boot_from_devices':
w+include/linux/kernel.h:45:30: warning: 'sizeof' on array function parameter 'spl_boot_list' will return size of 'u32 * {aka unsigned int *}' [-Wsizeof-array-argument]
Which I think is what Masahiro was pointing out :) So the rest of the
series needs some re-work following that too, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161128/f1a529a8/attachment.sig>
next prev parent reply other threads:[~2016-11-28 20:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 17:29 [U-Boot] [PATCH 0/8] spl: Move image loader names into the linker list Simon Glass
2016-11-17 17:29 ` [U-Boot] [PATCH 1/8] spl: Use a single underscore in the SPL_LOAD_IMAGE_METHOD() macro Simon Glass
2016-11-17 17:29 ` [U-Boot] [PATCH 2/8] spl: Add a name to the SPL load-image methods Simon Glass
2016-11-17 17:29 ` [U-Boot] [PATCH 3/8] spl: Move the loading code into its own function Simon Glass
2016-11-22 7:31 ` Masahiro Yamada
2016-11-28 20:09 ` Tom Rini [this message]
2016-11-28 20:19 ` [U-Boot] [U-Boot, " Simon Glass
2016-11-17 17:29 ` [U-Boot] [PATCH 4/8] spl: Pass the loader into spl_load_image() Simon Glass
2016-11-17 17:29 ` [U-Boot] [PATCH 5/8] spl: Drop announce_boot_device() Simon Glass
2016-11-17 17:29 ` [U-Boot] [PATCH 6/8] spl: sunxi: Drop spl_board_announce_boot_device() Simon Glass
2016-11-17 17:29 ` [U-Boot] [PATCH 7/8] spl: uniphier: " Simon Glass
2016-11-17 17:29 ` [U-Boot] [PATCH 8/8] spl: sandbox: " Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128200942.GP2546@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox