From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot,v2] timer: Support clocks via phandle
Date: Mon, 28 Nov 2016 19:49:14 -0500 [thread overview]
Message-ID: <20161129004914.GQ2546@bill-the-cat> (raw)
In-Reply-To: <1479574647-32326-1-git-send-email-vzakhar@synopsys.com>
On Sat, Nov 19, 2016 at 07:57:27PM +0300, Zakharov Vlad wrote:
> Earlier timer driver needed a clock-frequency property in compatible
> device-tree nodes. Another way is to reference a clock via a phandle.
>
> So now timer_pre_probe tries to get clock by reference through device
> tree. In case it is impossible to get clock device through the
> reference, clock-frequency property of the timer node is read to provide
> backward compatibility.
>
> Signed-off-by: Vlad Zakharov <vzakhar@synopsys.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
NAK:
sandbox: + sandbox_spl x
+(sandbox_spl) err = clk_get_by_index(dev, 0, timer_clk);
+(sandbox_spl) ^
w+(sandbox_spl) drivers/timer/timer-uclass.c: In function ?timer_pre_probe?:
w+(sandbox_spl) drivers/timer/timer-uclass.c:50:6: warning: ?timer_clk? is used uninitialized in this function [-Wuninitialized]
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161128/e6519008/attachment.sig>
prev parent reply other threads:[~2016-11-29 0:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-19 16:57 [U-Boot] [PATCH v2] timer: Support clocks via phandle Vlad Zakharov
2016-11-21 14:38 ` Vlad Zakharov
2016-11-21 14:51 ` Tom Rini
2016-11-21 15:50 ` Vlad Zakharov
2016-11-29 0:49 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129004914.GQ2546@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox