From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] xyz-modem: Change getc timeout loop waiting
Date: Mon, 28 Nov 2016 20:07:08 -0500 [thread overview]
Message-ID: <20161129010708.GI2546@bill-the-cat> (raw)
In-Reply-To: <1479716331-94776-1-git-send-email-tomas.melin@vaisala.com>
On Mon, Nov 21, 2016 at 10:18:51AM +0200, tomas.melin at vaisala.com wrote:
> This fixes the loop delay when using a hw watchdog.
>
> In case a watchdog is used that accesses CPU registers,
> the defined delay of 20us in a tight loop will cause a
> huge delay in the actual timeout seen. This is caused
> by the fact that udelay will inheritantly call WATCHDOG_RESET.
> Together with the omap wdt implementation, the seen timeout increases up to
> around 30s. This makes the loop very slow and causes long
> delays when using the modem.
>
> Instead, implement the 2 sec loop by using the timer interface to know
> when to break out of the timeout loop. Watchdog kicking is taken care of
> by getc().
>
> Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161128/1bd15f84/attachment.sig>
next prev parent reply other threads:[~2016-11-29 1:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 8:18 [U-Boot] [PATCH] xyz-modem: Change getc timeout loop waiting Tomas Melin
2016-11-29 1:07 ` Tom Rini [this message]
2018-08-01 0:15 ` [U-Boot] " Alexander Sverdlin
2018-08-01 5:44 ` Tomas Melin
2018-08-01 5:54 ` Alexander Sverdlin
2018-08-01 6:16 ` Tomas Melin
2018-08-02 14:47 ` Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129010708.GI2546@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox