From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/13] serial: 16550: Add getfcr accessor
Date: Thu, 1 Dec 2016 02:06:29 +0100 [thread overview]
Message-ID: <20161201010641.11529-1-marex@denx.de> (raw)
Add function which allows fetching the default FCR register setting
from platform data for DM , while retaining old behavior for non-DM
by returning UART_FCRVAL.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Tom Rini <trini@konsulko.com>
Cc: Simon Glass <sjg@chromium.org>
---
V2: If CONFIG_DM_SERIAL and DEBUG_UART are enabled, the ns16550_getfcr()
can be invoked with NULL plat data . Check for this case and return
the default UART_FCRVAL then.
V3: It turns out that if DEBUG_UART is defined, $port points directly to
hardware registers. Add additional ifdef to handle the case where
debug uart is enabled with DM_SERIAL correctly.
V4: Use UART_FCRVAL in _debug_uart_init() directly
---
drivers/serial/ns16550.c | 18 ++++++++++++++++--
include/ns16550.h | 1 +
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index 6e9b946..3c9f3b0 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -121,6 +121,13 @@ static int ns16550_readb(NS16550_t port, int offset)
return serial_in_shift(addr + plat->reg_offset, plat->reg_shift);
}
+static u32 ns16550_getfcr(NS16550_t port)
+{
+ struct ns16550_platdata *plat = port->plat;
+
+ return plat->fcr;
+}
+
/* We can clean these up once everything is moved to driver model */
#define serial_out(value, addr) \
ns16550_writeb(com_port, \
@@ -128,6 +135,11 @@ static int ns16550_readb(NS16550_t port, int offset)
#define serial_in(addr) \
ns16550_readb(com_port, \
(unsigned char *)addr - (unsigned char *)com_port)
+#else
+static u32 ns16550_getfcr(NS16550_t port)
+{
+ return UART_FCRVAL;
+}
#endif
int ns16550_calc_divisor(NS16550_t port, int clock, int baudrate)
@@ -171,7 +183,7 @@ void NS16550_init(NS16550_t com_port, int baud_divisor)
serial_out(0x7, &com_port->mdr1); /* mode select reset TL16C750*/
#endif
serial_out(UART_MCRVAL, &com_port->mcr);
- serial_out(UART_FCRVAL, &com_port->fcr);
+ serial_out(ns16550_getfcr(com_port), &com_port->fcr);
if (baud_divisor != -1)
NS16550_setbrg(com_port, baud_divisor);
#if defined(CONFIG_OMAP) || \
@@ -192,7 +204,7 @@ void NS16550_reinit(NS16550_t com_port, int baud_divisor)
serial_out(CONFIG_SYS_NS16550_IER, &com_port->ier);
NS16550_setbrg(com_port, 0);
serial_out(UART_MCRVAL, &com_port->mcr);
- serial_out(UART_FCRVAL, &com_port->fcr);
+ serial_out(ns16550_getfcr(com_port), &com_port->fcr);
NS16550_setbrg(com_port, baud_divisor);
}
#endif /* CONFIG_NS16550_MIN_FUNCTIONS */
@@ -420,6 +432,8 @@ int ns16550_serial_ofdata_to_platdata(struct udevice *dev)
return -EINVAL;
}
+ plat->fcr = UART_FCRVAL;
+
return 0;
}
#endif
diff --git a/include/ns16550.h b/include/ns16550.h
index 1311f4c..45fd68b 100644
--- a/include/ns16550.h
+++ b/include/ns16550.h
@@ -57,6 +57,7 @@ struct ns16550_platdata {
int reg_shift;
int clock;
int reg_offset;
+ u32 fcr;
};
struct udevice;
--
2.10.2
next reply other threads:[~2016-12-01 1:06 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 1:06 Marek Vasut [this message]
2016-12-01 1:06 ` [U-Boot] [PATCH 02/13] serial: 16550: Add port type as driver data Marek Vasut
2016-12-19 21:19 ` [U-Boot] [U-Boot, " Tom Rini
2016-12-01 1:06 ` [U-Boot] [PATCH 03/13] serial: 16550: Add Ingenic JZ4780 support Marek Vasut
2016-12-03 4:26 ` Simon Glass
2016-12-19 21:20 ` [U-Boot] [U-Boot, " Tom Rini
2016-12-01 1:06 ` [U-Boot] [PATCH 04/13] mmc: Fix warning if debug() is not used Marek Vasut
2016-12-01 4:17 ` Jaehoon Chung
2016-12-01 5:14 ` Jaehoon Chung
2016-12-01 1:06 ` [U-Boot] [PATCH 05/13] mmc: Tinification of the mmc code Marek Vasut
2016-12-01 5:07 ` Jaehoon Chung
2016-12-01 1:06 ` [U-Boot] [PATCH 06/13] mmc: Add JZ47xx SD/MMC controller driver Marek Vasut
2016-12-01 5:48 ` Jaehoon Chung
2017-02-12 14:20 ` Andreas Färber
2017-02-12 14:29 ` Marek Vasut
2017-02-12 14:56 ` Andreas Färber
2016-12-01 1:06 ` [U-Boot] [PATCH 07/13] SPL: mmc: Make spl_mmc_load_image available Marek Vasut
2016-12-01 5:07 ` Jaehoon Chung
2016-12-01 1:06 ` [U-Boot] [PATCH 08/13] gpio: Add JZ47xx GPIO driver Marek Vasut
2016-12-01 1:06 ` [U-Boot] [PATCH 09/13] misc: Add JZ47xx efuse driver Marek Vasut
2016-12-01 1:06 ` [U-Boot] [PATCH 10/13] mips: Add SPL header Marek Vasut
2016-12-01 1:06 ` [U-Boot] [PATCH 11/13] mips: jz47xx: Add JZ4780 SoC support Marek Vasut
2016-12-01 1:06 ` [U-Boot] [PATCH 12/13] mips: jz47xx: Add minimal JZ MMC node Marek Vasut
2016-12-01 1:06 ` [U-Boot] [PATCH 13/13] mips: jz47xx: Add Creator CI20 platform Marek Vasut
2017-02-12 11:52 ` Andreas Färber
2017-02-12 11:55 ` Marek Vasut
2017-02-12 12:24 ` Andreas Färber
2017-02-12 12:53 ` Marek Vasut
2017-02-12 13:24 ` Andreas Färber
2017-02-12 14:03 ` Marek Vasut
2017-06-11 21:45 ` Andreas Färber
2017-06-12 19:16 ` Tom Rini
2017-02-12 14:14 ` Andreas Färber
2017-02-14 22:58 ` Tom Rini
2017-02-14 23:03 ` Marek Vasut
2017-02-14 23:11 ` Tom Rini
2017-02-15 20:46 ` Marek Vasut
2017-02-15 21:50 ` Tom Rini
2017-02-15 22:08 ` Marek Vasut
2016-12-03 4:26 ` [U-Boot] [PATCH 01/13] serial: 16550: Add getfcr accessor Simon Glass
2016-12-19 21:18 ` [U-Boot] [U-Boot,01/13] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201010641.11529-1-marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox