U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] disk: convert to Kconfig
Date: Fri, 2 Dec 2016 08:18:32 -0500	[thread overview]
Message-ID: <20161202131832.GK2546@bill-the-cat> (raw)
In-Reply-To: <1480667094-15253-1-git-send-email-patrick.delaunay73@gmail.com>

On Fri, Dec 02, 2016 at 09:24:54AM +0100, Patrick Delaunay wrote:

> This converts the following to Kconfig:
>            CONFIG_PARTITIONS
>            CONFIG_MAC_PARTITION
>            CONFIG_DOS_PARTITION
>            CONFIG_ISO_PARTITION
>            CONFIG_AMIGA_PARTITION
>            CONFIG_EFI_PARTITION
>            CONFIG_PARTITION_UUIDS
>            CONFIG_PARTITION_TYPE_GUID
[snip]
>  606 files changed, 996 insertions(+), 583 deletions(-)

The insertions to deletions ratio is still high, and I think we can do a
little better.  Some of this is due to platforms that I fix with
https://patchwork.ozlabs.org/patch/700546/ and will have the various
types selected now.  But I think we can still do a little better with
defaults too:

[snip]
> +config ISO_PARTITION
> +	bool "Enable ISO partition table"
> +	depends on PARTITIONS

This should be default y for x86, along with DOS and MAC.

> +config SPL_ISO_PARTITION
> +	bool "Enable ISO partition table for SPL"
> +	depends on SPL && PARTITIONS

Here and elsewhere, SPL_xxx_PARTITION should be default y if
xxx_PARTITION

> +config PARTITION_UUIDS
> +	bool "Enable support of UUID for partition"
> +	help
> +	  Activate the configuration of UUID for partition

I think a lot of these will go away once CMD_GPT and CMD_PART are
converted to Kconfig, but I don't want to chicken-and-egg this nor have
too many things in flight at once, so lets put that off until after this
series.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161202/9793a367/attachment.sig>

  reply	other threads:[~2016-12-02 13:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02  8:24 [U-Boot] [PATCH v2] disk: convert to Kconfig Patrick Delaunay
2016-12-02 13:18 ` Tom Rini [this message]
2016-12-02 17:23   ` Patrick DELAUNAY
2016-12-02 20:29     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161202131832.GK2546@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox