* [U-Boot] [RFC PATCH] mmc: spear: remove the entire spear_sdhci.c file
@ 2016-12-02 8:46 Jaehoon Chung
2016-12-02 14:04 ` Tom Rini
0 siblings, 1 reply; 3+ messages in thread
From: Jaehoon Chung @ 2016-12-02 8:46 UTC (permalink / raw)
To: u-boot
Remove the entire spear_sdhci.c file.
There is no use case. This is dead codes.
Also there is no place to call "spear_sdhci_init()" anywhere.
If some people use this file, let me know, plz.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
drivers/mmc/Makefile | 1 -
drivers/mmc/spear_sdhci.c | 27 ---------------------------
2 files changed, 28 deletions(-)
delete mode 100644 drivers/mmc/spear_sdhci.c
diff --git a/drivers/mmc/Makefile b/drivers/mmc/Makefile
index d850758..94da954 100644
--- a/drivers/mmc/Makefile
+++ b/drivers/mmc/Makefile
@@ -52,7 +52,6 @@ obj-$(CONFIG_SDHCI) += sdhci.o
obj-$(CONFIG_SH_MMCIF) += sh_mmcif.o
obj-$(CONFIG_SH_SDHI) += sh_sdhi.o
obj-$(CONFIG_SOCFPGA_DWMMC) += socfpga_dw_mmc.o
-obj-$(CONFIG_SPEAR_SDHCI) += spear_sdhci.o
obj-$(CONFIG_TEGRA_MMC) += tegra_mmc.o
obj-$(CONFIG_MMC_UNIPHIER) += uniphier-sd.o
obj-$(CONFIG_ZYNQ_SDHCI) += zynq_sdhci.o
diff --git a/drivers/mmc/spear_sdhci.c b/drivers/mmc/spear_sdhci.c
deleted file mode 100644
index 06179cd..0000000
--- a/drivers/mmc/spear_sdhci.c
+++ /dev/null
@@ -1,27 +0,0 @@
-/*
- * (C) Copyright 2012
- * Vipin Kumar, ST Micoelectronics, vipin.kumar at st.com.
- *
- * SPDX-License-Identifier: GPL-2.0+
- */
-
-#include <common.h>
-#include <malloc.h>
-#include <sdhci.h>
-
-int spear_sdhci_init(u32 regbase, u32 max_clk, u32 min_clk, u32 quirks)
-{
- struct sdhci_host *host = NULL;
- host = (struct sdhci_host *)malloc(sizeof(struct sdhci_host));
- if (!host) {
- printf("sdhci host malloc fail!\n");
- return 1;
- }
-
- host->name = "sdhci";
- host->ioaddr = (void *)regbase;
- host->quirks = quirks;
-
- add_sdhci(host, max_clk, min_clk);
- return 0;
-}
--
2.10.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [RFC PATCH] mmc: spear: remove the entire spear_sdhci.c file
2016-12-02 8:46 [U-Boot] [RFC PATCH] mmc: spear: remove the entire spear_sdhci.c file Jaehoon Chung
@ 2016-12-02 14:04 ` Tom Rini
2016-12-19 7:52 ` Jaehoon Chung
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rini @ 2016-12-02 14:04 UTC (permalink / raw)
To: u-boot
On Fri, Dec 02, 2016 at 05:46:10PM +0900, Jaehoon Chung wrote:
> Remove the entire spear_sdhci.c file.
> There is no use case. This is dead codes.
> Also there is no place to call "spear_sdhci_init()" anywhere.
>
> If some people use this file, let me know, plz.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
It looks like it was added as dead code so:
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161202/36c0e59b/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [RFC PATCH] mmc: spear: remove the entire spear_sdhci.c file
2016-12-02 14:04 ` Tom Rini
@ 2016-12-19 7:52 ` Jaehoon Chung
0 siblings, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2016-12-19 7:52 UTC (permalink / raw)
To: u-boot
On 12/02/2016 11:04 PM, Tom Rini wrote:
> On Fri, Dec 02, 2016 at 05:46:10PM +0900, Jaehoon Chung wrote:
>
>> Remove the entire spear_sdhci.c file.
>> There is no use case. This is dead codes.
>> Also there is no place to call "spear_sdhci_init()" anywhere.
>>
>> If some people use this file, let me know, plz.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>
> It looks like it was added as dead code so:
>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied on u-boot-mmc. Thanks!
Best Regards,
Jaehoon Chung
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-19 7:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-02 8:46 [U-Boot] [RFC PATCH] mmc: spear: remove the entire spear_sdhci.c file Jaehoon Chung
2016-12-02 14:04 ` Tom Rini
2016-12-19 7:52 ` Jaehoon Chung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox