From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 2 Dec 2016 15:17:47 -0500 Subject: [U-Boot] [PATCH] arm: am33xx: Initialize EMIF REG_PR_OLD_COUNT for BBB and am335x-evm In-Reply-To: References: <1480665279-19758-1-git-send-email-jsarha@ti.com> <20161202130151.GJ2546@bill-the-cat> Message-ID: <20161202201747.GT2546@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Dec 02, 2016 at 06:24:49PM +0200, Jyri Sarha wrote: > On 12/02/16 15:06, Jyri Sarha wrote: > >>> diff --git a/arch/arm/include/asm/arch-am33xx/ddr_defs.h b/arch/arm/include/asm/arch-am33xx/ddr_defs.h > >>> >> index 43e122e..c71cfd0 100644 > >>> >> --- a/arch/arm/include/asm/arch-am33xx/ddr_defs.h > >>> >> +++ b/arch/arm/include/asm/arch-am33xx/ddr_defs.h > >>> >> @@ -25,6 +25,14 @@ > >>> >> #endif > >>> >> #define PHY_EN_DYN_PWRDN (0x1 << 20) > >>> >> > >>> >> +/** > >>> >> + * AM335X (EMIF_4D) EMIF REG_COS_COUNT_1, REG_COS_COUNT_2, and > >>> >> + * REG_PR_OLD_COUNT values to avoid LCDC DMA FIFO underflows and Frame > >>> >> + * Synchronization Lost errors. > >>> >> + */ > >>> >> +#define EMIF_OCP_CONFIG_BEAGLEBONE_BLACK 0x00141414 > >>> >> +#define EMIF_OCP_CONFIG_AM335X_EVM 0x003d3d3d > >> > > >> > OK, but the problems I see are that first we don't explain what these > >> > values are tied to physically. Is it the display? The DDR memory? > > It is a combination of both. I'll add that to the comment. > > > >> > Second, since these are board specific they should be in > >> > board/ti/am335x/board.h. Thanks! > >> > > > Ok, I'll move the defines there. > > Hmmmm, there there are no defined constants in board/ti/am335x/board.h. > Should I just put the constants above, with improved comment, somewhere > in that file? Yes, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: