From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] arm: am57xx: cl-som-am57x: add initial board support
Date: Sun, 4 Dec 2016 09:26:17 -0500 [thread overview]
Message-ID: <20161204142617.GJ4248@bill-the-cat> (raw)
In-Reply-To: <36e83deb-4ffa-0ccf-9949-b51e596100fd@compulab.co.il>
On Sun, Dec 04, 2016 at 09:58:42AM +0200, Uri Mashiach wrote:
> Hello Tom,
>
> On 12/01/2016 05:36 PM, Tom Rini wrote:
> > On Thu, Dec 01, 2016 at 10:28:12AM +0200, Uri Mashiach wrote:
> >
> >> From: Dmitry Lifshitz <lifshitz@compulab.co.il>
> >>
> >> Features supported :
> >>
> >> * Serial console
> >> * SPI Flash
> >> * MMC/SD Card
> >> * eMMC storage
> >> * SATA
> >> * PCA9555 - GPIO expander over I2C5 bus
> >> * USB
> >>
> >> Signed-off-by: Dmitry Lifshitz <lifshitz@compulab.co.il>
> >> [uri.mashiach at compulab.co.il: Adjust to v2016.11]
> >> Signed-off-by: Uri Mashiach <uri.mashiach@compulab.co.il>
> >> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> >
> > In general:
> >
> > Reviewed-by: Tom Rini <trini@konsulko.com>
> >
> > [snip]
> >> +/* Status LED */
> >> +#define CONFIG_STATUS_LED /* Status LED enabled */
> >> +#define CONFIG_GPIO_LED
> >> +#define CONFIG_BOARD_SPECIFIC_LED
> >> +#define GREEN_LED_DEV 0
> >> + /* cl_som_am57x Green LED is GPIO2_5 */
> >> +#define GREEN_LED_GPIO 37
> >> +#define STATUS_LED_BIT GREEN_LED_GPIO
> >> +#define STATUS_LED_STATE STATUS_LED_ON
> >> +#define STATUS_LED_PERIOD (CONFIG_SYS_HZ / 2)
> >
> > Do you have time to look at moving CONFIG_STATUS_LED and related defines
> > to Kconfig (or where makes more sense, include/status_led.h) ? I see
> > this is used on a few CompuLab boards so you'd be able to test the
> > changes as well, thanks!
>
> I prefer that the CL-COM-AM57x module will be included the next release.
> The Kconfig migration of the status LED will be sent as a separate
> patch set.
> Please let me know which of the following options is preferred:
> 1. Remove the current patch from the set and add a separate patch
> after the Kconfig migration of the status LED.
> 2. Leave the current patch in the patch set and send a
> separated update patch after the Kconfig migration of the status LED.
I'm OK with 2 since you're committing to do the work, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161204/a648e71f/attachment.sig>
next prev parent reply other threads:[~2016-12-04 14:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 8:28 [U-Boot] [PATCH 0/5] cl-som-am57x: initial support Uri Mashiach
2016-12-01 8:28 ` [U-Boot] [PATCH 1/5] arm: am57xx: cl-som-am57x: add initial board support Uri Mashiach
2016-12-01 15:36 ` Tom Rini
2016-12-04 7:58 ` Uri Mashiach
2016-12-04 14:26 ` Tom Rini [this message]
2016-12-01 8:28 ` [U-Boot] [PATCH 2/5] arm: am57xx: cl-som-am57x: add MMC as a boot devices for spl Uri Mashiach
2016-12-01 15:37 ` Tom Rini
2016-12-01 8:28 ` [U-Boot] [PATCH 3/5] arm: am57xx: cl-som-am57x: fetch board rev from EEPROM Uri Mashiach
2016-12-01 15:37 ` Tom Rini
2016-12-01 8:28 ` [U-Boot] [PATCH 4/5] arm: am57xx: cl-som-am57x: add ETH support Uri Mashiach
2016-12-01 15:38 ` Tom Rini
2016-12-01 8:28 ` [U-Boot] [PATCH 5/5] arm: am57xx: cl-som-am57x: update default env Uri Mashiach
2016-12-01 15:39 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161204142617.GJ4248@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox