From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] check_config.sh produces false positive error?
Date: Mon, 5 Dec 2016 11:34:47 -0500 [thread overview]
Message-ID: <20161205163447.GO4248@bill-the-cat> (raw)
In-Reply-To: <CALw8SCUn5BGy=DcWXJ1NEEoOHzO63k_1w5wC+LJHPkGz2to2+w@mail.gmail.com>
On Sun, Dec 04, 2016 at 08:52:35PM +0100, Mirza Krak wrote:
> Hi.
>
> Recently a check was added to if new ad-hoc CONFIG options where added
> and produced an error. The exact commit is [1].
>
> While building (2016.11) with some out of tree files in include folder
> I get the following error:
>
> Build error:
> | Error: You must add new CONFIG options using Kconfig
> | The following new ad-hoc CONFIG options were detected:
> | CONFIG_MENDER_H
> |
> | Please add these via Kconfig instead. Find a suitable Kconfig
> | file and add a 'config' or 'menuconfig' option.
>
> As you can see above that this is not a new configuration option but a
> header guard. Probably not the best naming convention here, but still
> I wonder if the check_config.sh script should produce errors in cases
> like the one above? The common practice in u-boot is to use _H as
> part of a header guard name (as far as I can see at least) so maybe
> that should be added to the regexp in check_config.sh?
I'm indifferent. If you patch it and it looks clean, OK. But on the
other hand, header guards should be _HEADER_PATH_AND_NAME_H_ (and I
mildly wonder if checkpatch.pl catches this).
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161205/fa1b2fc3/attachment.sig>
next prev parent reply other threads:[~2016-12-05 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 19:52 [U-Boot] check_config.sh produces false positive error? Mirza Krak
2016-12-05 16:34 ` Tom Rini [this message]
2016-12-05 22:05 ` Mirza Krak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205163447.GO4248@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox