From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 5 Dec 2016 11:34:47 -0500 Subject: [U-Boot] check_config.sh produces false positive error? In-Reply-To: References: Message-ID: <20161205163447.GO4248@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, Dec 04, 2016 at 08:52:35PM +0100, Mirza Krak wrote: > Hi. > > Recently a check was added to if new ad-hoc CONFIG options where added > and produced an error. The exact commit is [1]. > > While building (2016.11) with some out of tree files in include folder > I get the following error: > > Build error: > | Error: You must add new CONFIG options using Kconfig > | The following new ad-hoc CONFIG options were detected: > | CONFIG_MENDER_H > | > | Please add these via Kconfig instead. Find a suitable Kconfig > | file and add a 'config' or 'menuconfig' option. > > As you can see above that this is not a new configuration option but a > header guard. Probably not the best naming convention here, but still > I wonder if the check_config.sh script should produce errors in cases > like the one above? The common practice in u-boot is to use _H as > part of a header guard name (as far as I can see at least) so maybe > that should be added to the regexp in check_config.sh? I'm indifferent. If you patch it and it looks clean, OK. But on the other hand, header guards should be _HEADER_PATH_AND_NAME_H_ (and I mildly wonder if checkpatch.pl catches this). -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: