From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 5 Dec 2016 14:00:21 -0500 Subject: [U-Boot] [RFC PACH v2 1/1] Add vexpress_aemv8a_aarch32 variant In-Reply-To: References: <1480954305-11770-1-git-send-email-ryan.harkin@linaro.org> <20161205171304.GQ4248@bill-the-cat> Message-ID: <20161205190021.GR4248@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Dec 05, 2016 at 06:01:48PM +0000, Ryan Harkin wrote: > Hi Tom, > [snip] > At the moment, the BASE_FVP_DRAM version is a clone of the BASE_FVP > code, just with a different bootcmd. Now the AARCH32 is another clone > with CPU_V7 and bootz instead of booti. > > I'd be interested to know if there is a better way to handle those > small variations. A better structured header than vexpress_aemv8a.h > would be a good start, of course. The very new include/environment/ directory would be the place to put these various environment bits (probably under armltd/) and then you could probably do something like: #ifdef CONFIG_ARM64 #define BOARD_BOOTCMD "booti" #else #define BOARD_BOOTCMD "bootz" #endif #define BOOTCOMMAND "..." \ BOARD_BOOTCMD + " $loadaddr - $fdtaddr" And add some other choice / bools to board/armltd/vexpress/Kconfig to enable/disable other environment things as needed. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: