[U-Boot] [PATCH 0/2] davinci: omapl138_lcdk: fix unreliable NAND accesses

[U-Boot] [PATCH 0/2] davinci: omapl138_lcdk: fix unreliable NAND accesses

[Fabien Parent]

A couple of issue made the NAND accesses unreliable. This patchset aims to
fix all the NAND issues with the OMAP-L138-LCDK.

Fabien Parent (2):
  davinci: omapl138_lcdk: increase u-boot load size
  davinci: omapl138_lcdk: fix bad NAND ECC config

 include/configs/omapl138_lcdk.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

-- 
2.11.0

[U-Boot] [PATCH 1/2] davinci: omapl138_lcdk: increase u-boot load size

[Fabien Parent]

A size of 0x200 seems way too short for u-boot. Increase the size
to 512k.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
 include/configs/omapl138_lcdk.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/omapl138_lcdk.h b/include/configs/omapl138_lcdk.h
index 9e11f7dc95..2101086d59 100644
--- a/include/configs/omapl138_lcdk.h
+++ b/include/configs/omapl138_lcdk.h
@@ -176,7 +176,7 @@
 #define CONFIG_SYS_NAND_5_ADDR_CYCLE
 #define CONFIG_SYS_NAND_PAGE_SIZE	(2 << 10)
 #define CONFIG_SYS_NAND_BLOCK_SIZE	(128 << 10)
-#define CONFIG_SYS_NAND_U_BOOT_SIZE	0x200 /*0x60000*/
+#define CONFIG_SYS_NAND_U_BOOT_SIZE	SZ_512K
 #define CONFIG_SYS_NAND_U_BOOT_DST	0xc1080000
 #define CONFIG_SYS_NAND_U_BOOT_START	CONFIG_SYS_NAND_U_BOOT_DST
 #define CONFIG_SYS_NAND_U_BOOT_RELOC_SP	(CONFIG_SYS_NAND_U_BOOT_DST - \
-- 
2.11.0

[U-Boot] [PATCH 2/2] davinci: omapl138_lcdk: fix bad NAND ECC config

[Fabien Parent]

The configuration used to error correction was not in line with what
linux and the ROM code is using. Fix it by using the correct
configuration. Now u-boot and the SPL are able to read correctly
anything written by them.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
 include/configs/omapl138_lcdk.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/configs/omapl138_lcdk.h b/include/configs/omapl138_lcdk.h
index 2101086d59..a1e5f4481f 100644
--- a/include/configs/omapl138_lcdk.h
+++ b/include/configs/omapl138_lcdk.h
@@ -173,6 +173,7 @@
 #undef CONFIG_SYS_NAND_HW_ECC
 #define CONFIG_SYS_MAX_NAND_DEVICE	1 /* Max number of NAND devices */
 #define CONFIG_SYS_NAND_HW_ECC_OOBFIRST
+#define CONFIG_NAND_6BYTES_OOB_FREE_10BYTES_ECC
 #define CONFIG_SYS_NAND_5_ADDR_CYCLE
 #define CONFIG_SYS_NAND_PAGE_SIZE	(2 << 10)
 #define CONFIG_SYS_NAND_BLOCK_SIZE	(128 << 10)
@@ -184,11 +185,10 @@
 					CONFIG_SYS_MALLOC_LEN -       \
 					GENERATED_GBL_DATA_SIZE)
 #define CONFIG_SYS_NAND_ECCPOS		{				\
-				24, 25, 26, 27, 28, \
-				29, 30, 31, 32, 33, 34, 35, 36, 37, 38, \
-				39, 40, 41, 42, 43, 44, 45, 46, 47, 48, \
-				49, 50, 51, 52, 53, 54, 55, 56, 57, 58, \
-				59, 60, 61, 62, 63 }
+				6, 7, 8, 9, 10, 11, 12, 13, 14, 15,	\
+				22, 23, 24, 25, 26, 27, 28, 29, 30, 31, \
+				38, 39, 40, 41, 42, 43, 44, 45, 46, 47, \
+				54, 55, 56, 57, 58, 59, 60, 61, 62, 63 }
 #define CONFIG_SYS_NAND_PAGE_COUNT	64
 #define CONFIG_SYS_NAND_BAD_BLOCK_POS	0
 #define CONFIG_SYS_NAND_ECCSIZE		512
-- 
2.11.0

[U-Boot] [PATCH 1/2] davinci: omapl138_lcdk: increase u-boot load size

[Tom Rini]

On Mon, Dec 05, 2016 at 07:15:20PM +0100, Fabien Parent wrote:

> A size of 0x200 seems way too short for u-boot. Increase the size
> to 512k.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161205/26ca0516/attachment.sig>

[U-Boot] [PATCH 2/2] davinci: omapl138_lcdk: fix bad NAND ECC config

[Tom Rini]

On Mon, Dec 05, 2016 at 07:15:21PM +0100, Fabien Parent wrote:

> The configuration used to error correction was not in line with what
> linux and the ROM code is using. Fix it by using the correct
> configuration. Now u-boot and the SPL are able to read correctly
> anything written by them.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161205/9bd40302/attachment.sig>

[U-Boot] [U-Boot, 1/2] davinci: omapl138_lcdk: increase u-boot load size

[Tom Rini]

On Mon, Dec 05, 2016 at 07:15:20PM +0100, Fabien Parent wrote:

> A size of 0x200 seems way too short for u-boot. Increase the size
> to 512k.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161212/a3fb0d46/attachment.sig>

[U-Boot] [U-Boot, 2/2] davinci: omapl138_lcdk: fix bad NAND ECC config

[Tom Rini]

On Mon, Dec 05, 2016 at 07:15:21PM +0100, Fabien Parent wrote:

> The configuration used to error correction was not in line with what
> linux and the ROM code is using. Fix it by using the correct
> configuration. Now u-boot and the SPL are able to read correctly
> anything written by them.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161212/e3d399e0/attachment.sig>