public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Fabien Parent <fparent@baylibre.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] davinci: spl: use correct macro to select boot device
Date: Tue,  6 Dec 2016 14:48:28 +0100	[thread overview]
Message-ID: <20161206134830.22130-2-fparent@baylibre.com> (raw)
In-Reply-To: <20161206134830.22130-1-fparent@baylibre.com>

The macro used to select the boot device is not the intended one. It
should be CONFIG_SPL_NAND_LOAD and not CONFIG_SPL_NAND_SIMPLE.

Using the correct config option will help move them to Kconfig option.

Every davinci board that use the SPL are defining both
CONFIG_SPL_NAND_LOAD and CONFIG_SPL_NAND_SIMPLE at the same place, so
there should be no issue created by this change.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
 arch/arm/mach-davinci/spl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-davinci/spl.c b/arch/arm/mach-davinci/spl.c
index 0aeaa7d8b7..9d5a173701 100644
--- a/arch/arm/mach-davinci/spl.c
+++ b/arch/arm/mach-davinci/spl.c
@@ -52,7 +52,7 @@ u32 spl_boot_mode(const u32 boot_device)
 
 u32 spl_boot_device(void)
 {
-#ifdef CONFIG_SPL_NAND_SIMPLE
+#ifdef CONFIG_SPL_NAND_LOAD
 	return BOOT_DEVICE_NAND;
 #elif defined(CONFIG_SPL_SPI_LOAD)
 	return BOOT_DEVICE_SPI;
-- 
2.11.0

  reply	other threads:[~2016-12-06 13:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-06 13:48 [U-Boot] [PATCH 0/3] SPL: move CONFIG_SPL_*_LOAD to Kconfig Fabien Parent
2016-12-06 13:48 ` Fabien Parent [this message]
2016-12-06 13:48 ` [U-Boot] [PATCH 2/3] SPL: create Kconfig options for CONFIG_SPL_*_LOAD Fabien Parent
2016-12-06 13:48 ` [U-Boot] [PATCH 3/3] davinci: omapl138_lcdk: use new CONFIG_SPL_*_LOAD Kconfig options Fabien Parent
2016-12-06 14:32 ` [U-Boot] [PATCH 0/3] SPL: move CONFIG_SPL_*_LOAD to Kconfig Tom Rini
2016-12-06 15:57   ` Igor Grinberg
2016-12-06 16:01     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161206134830.22130-2-fparent@baylibre.com \
    --to=fparent@baylibre.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox