From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 19 Dec 2016 16:59:40 -0500 Subject: [U-Boot] [PATCH 1/3] ARM: revive CONFIG_USE_ARCH_MEMCPY/MEMSET for UniPhier and Tegra In-Reply-To: <1482143465-14584-2-git-send-email-yamada.masahiro@socionext.com> References: <1482143465-14584-1-git-send-email-yamada.masahiro@socionext.com> <1482143465-14584-2-git-send-email-yamada.masahiro@socionext.com> Message-ID: <20161219215940.GL4248@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Dec 19, 2016 at 07:31:02PM +0900, Masahiro Yamada wrote: > Commit be72591bcd64 ("Kconfig: Move USE_ARCH_MEMCPY/MEMSET to > Kconfig") is misconversion. > > The original logic in include/configs/uniphier.h was as follows: > > #if !defined(CONFIG_SPL_BUILD) && !defined(CONFIG_ARM64) > #define CONFIG_USE_ARCH_MEMSET > #define CONFIG_USE_ARCH_MEMCPY > #endif > > This means those configs were enabled when building U-Boot proper, > but disabled when building SPL. Likewise for Tegra. > > Now "depends on !SPL" prevents any boards with SPL support > from reaching these options. This changed the behavior for > UniPhier and Tegra SoC family. > > Please notice these two options only control the U-Boot proper > build. As you see arch/arm/Makefile, ARM-specific memset/memcpy > are never compiled for SPL. So, __HAVE_ARCH_MEMCPY/MEMSET should > not set for SPL. > > Fixes: be72591bcd64 ("Kconfig: Move USE_ARCH_MEMCPY/MEMSET to Kconfig") > Signed-off-by: Masahiro Yamada Ah, oops, thanks for spotting that one. > --- > > I am restoring the original behavior for now. > But, I have been wondering if we could remove these options entirely. We cannot. That was my first attempt and we have a handful of active (I checked) boards with tiny enough SPL constraints that switching to the optimized memcpy/memset push them over size limit and they do not have a "something" to disable to gain the space back. So I went with asking for asking for a conversion to enable by default these options as widely as possible as it's a good thing by and (no pun intended) large. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: