public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fs/ext4: Initialize group descriptor size for revision level 0 filesystems
Date: Tue, 27 Dec 2016 11:18:20 -0500	[thread overview]
Message-ID: <20161227161820.GK4248@bill-the-cat> (raw)
In-Reply-To: <164779100.v4krVsGcBX@pebbles.site>

On Tue, Dec 27, 2016 at 05:15:45PM +0100, Stefan Bruens wrote:
> On Dienstag, 27. Dezember 2016 10:44:07 CET Kever Yang wrote:
> > Hi Stefan,
> > 
> >      With this patch, the image create by genext2fs can be mount in
> > U-Boot, thanks.
> 
> Thanks for testing.
> 
> @Tom: this is probably a candidate for u-boot 2017.01 ...

Thanks, I'm putting this and some other changes through their paces now.

>  
> > On 12/27/2016 09:35 AM, Stefan Br?ns wrote:
> > > genext2fs creates revision level 0 filesystems, which are not readable
> > > by u-boot due to the initialized group descriptor size field.
> > > f798b1dda1c5de818b806189e523d1b75db7e72d
> > > 
> > > Reported-by: Kever Yang <kever.yang@rock-chips.com>
> > > Reported-by: FrostyBytes at protonmail.com
> > > Signed-off-by: Stefan Br?ns <stefan.bruens@rwth-aachen.de>
> > > ---
> > > 
> > >   fs/ext4/ext4_common.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c
> > > index bfebe7e379..621c61e5c7 100644
> > > --- a/fs/ext4/ext4_common.c
> > > +++ b/fs/ext4/ext4_common.c
> > > @@ -2334,6 +2334,7 @@ int ext4fs_mount(unsigned part_length)
> > > 
> > >   	if (le32_to_cpu(data->sblock.revision_level) == 0) {
> > >   	
> > >   		fs->inodesz = 128;
> > > 
> > > +		fs->gdsize = 32;
> > > 
> > >   	} else {
> > >   	
> > >   		debug("EXT4 features COMPAT: %08x INCOMPAT: %08x RO_COMPAT: %08x\n",
> > >   		
> > >   		      __le32_to_cpu(data->sblock.feature_compatibility),
> > 
> > Tested-by: Kever Yang <kever.yang@rock-chips.com>
> > 
> > Thanks,
> > - Kever
> 
> 
> -- 
> Stefan Br?ns  /  Bergstra?e 21  /  52062 Aachen
> home: +49 241 53809034     mobile: +49 151 50412019
> work: +49 2405 49936-424

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161227/7965c018/attachment.sig>

  reply	other threads:[~2016-12-27 16:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-27  1:35 [U-Boot] [PATCH] fs/ext4: Initialize group descriptor size for revision level 0 filesystems Stefan Brüns
2016-12-27  2:44 ` Kever Yang
2016-12-27 16:15   ` Stefan Bruens
2016-12-27 16:18     ` Tom Rini [this message]
2016-12-29 22:40 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161227161820.GK4248@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox