From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] lib: net_utils: make string_to_ip stricter
Date: Wed, 04 Jan 2017 11:04:42 +0100 [thread overview]
Message-ID: <20170104100442.76F0910113B@atlas.denx.de> (raw)
In-Reply-To: <20170104003626.4211-1-judge.packham@gmail.com>
Dear Chris,
In message <20170104003626.4211-1-judge.packham@gmail.com> you wrote:
>
> With the input "1234192.168.1.1" the old behaviour would truncate the
> address to 192.168.1.1. New behaviour rejects the string outright and
> returns 0.0.0.0, which for the purposes of IP addresses can be
> considered an error.
Does code that calls string_to_ip() check for such an error
condition?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Listen to the local yokel yodel.
next prev parent reply other threads:[~2017-01-04 10:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 22:01 [U-Boot] [PATCH] lib: net_utils: make string_to_ip stricter Chris Packham
2016-12-26 5:23 ` Simon Glass
2016-12-26 8:56 ` Chris Packham
2017-01-04 0:36 ` [U-Boot] [PATCH v2 1/2] " Chris Packham
2017-01-04 0:36 ` [U-Boot] [PATCH v2 2/2] lib: net_utils: enforce '.' as octet separator in string_to_ip Chris Packham
2017-01-04 10:09 ` Wolfgang Denk
2017-01-05 8:17 ` Chris Packham
2017-01-08 18:45 ` Wolfgang Denk
2017-01-09 8:21 ` Chris Packham
2017-01-15 18:30 ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-01-04 10:04 ` Wolfgang Denk [this message]
2017-01-05 7:58 ` [U-Boot] [PATCH v2 1/2] lib: net_utils: make string_to_ip stricter Chris Packham
2017-01-15 18:30 ` [U-Boot] [U-Boot, v2, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104100442.76F0910113B@atlas.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox