public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 6/14] cmd: Add Kconfig option for CMD_MTDPARTS and related options
Date: Wed, 4 Jan 2017 10:10:56 +0100	[thread overview]
Message-ID: <20170104101056.18a5069e@bbrezillon> (raw)
In-Reply-To: <4fdcc47c7f580f43cd5cd5e7b10517e1f8699c65.1479817585.git-series.maxime.ripard@free-electrons.com>

Hi Maxime,

On Tue, 22 Nov 2016 13:38:36 +0100
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> CMD_MTDPARTS is something the user might or might not want to select, and
> might depends on (or be selected by) other options too.
> 
> This is even truer for the MTDIDS_DEFAULT and MTDPARTS_DEFAULT options that
> might change from one board to another, or from one user to the other,
> depending on what it expects and what storage devices are available.
> 
> In order to ease that configuration, add those options to Kconfig.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  cmd/Kconfig    | 19 +++++++++++++++++++
>  cmd/mtdparts.c |  8 ++++++++
>  2 files changed, 27 insertions(+), 0 deletions(-)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index e339d8638aa5..cd98e2a2bd00 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -717,6 +717,25 @@ config CMD_FS_GENERIC
>  	help
>  	  Enables filesystem commands (e.g. load, ls) that work for multiple
>  	  fs types.
> +
> +config CMD_MTDPARTS
> +	bool "MTD partition support"

	depends on MTD

Also, it seems that MTD_DEVICE and MTD_PARTITIONS still have to be
defined in the board/soc config header, which is kind of disturbing.

I modified the patch (see below) to add hidden MTD_DEVICE and
MTD_PARTITIONS options and select them from MTDPARTS. This way you can
get rid of all MTD related definitions in sunxi-common.h.

I also have 3 more patches [1][2][3] to expose UBIFS and NAND suboptions
through Kconfig in order to get rid of the extra definitions you add in
sunxi-common.h (patch 9). Let me know if you want me to send them
separately, otherwise, you can include them in your series.

Regards,

Boris

[1]http://code.bulix.org/l9ca0i-107843
[2]http://code.bulix.org/29dzqe-107844
[3]http://code.bulix.org/hp7y46-107845

--->8---

  parent reply	other threads:[~2017-01-04  9:10 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22 12:38 [U-Boot] [PATCH v2 0/14] sunxi: Add support for the CHIP Pro Maxime Ripard
2016-11-22 12:38 ` [U-Boot] [PATCH v2 1/14] nand: sunxi: Fix modulo by zero error Maxime Ripard
2016-11-22 12:43   ` Boris Brezillon
2017-01-04 22:11   ` Scott Wood
2016-11-22 12:38 ` [U-Boot] [PATCH v2 2/14] mtd: nand: add support for the TC58NVG2S0H chip Maxime Ripard
2016-11-22 12:38 ` [U-Boot] [PATCH v2 3/14] bch: Allow to build for the host Maxime Ripard
2016-11-22 15:12   ` Tom Rini
2016-11-25 17:05   ` Jagan Teki
2016-11-29  8:49     ` Maxime Ripard
2016-11-22 12:38 ` [U-Boot] [PATCH v2 4/14] tools: sunxi: Add spl image builder Maxime Ripard
2016-11-22 12:38 ` [U-Boot] [PATCH v2 5/14] common: Move environment choice to Kconfig Maxime Ripard
2016-11-22 15:17   ` Tom Rini
2016-11-22 12:38 ` [U-Boot] [PATCH v2 6/14] cmd: Add Kconfig option for CMD_MTDPARTS and related options Maxime Ripard
2016-11-22 15:14   ` Tom Rini
2017-01-04  9:10   ` Boris Brezillon [this message]
2017-01-09  8:28     ` Maxime Ripard
2016-11-22 12:38 ` [U-Boot] [PATCH v2 7/14] mtd: sunxi: Select the U-Boot location config option Maxime Ripard
2016-11-22 12:38 ` [U-Boot] [PATCH v2 8/14] mtd: sunxi: Change U-Boot offset Maxime Ripard
2016-11-22 15:20   ` Tom Rini
2016-11-22 12:38 ` [U-Boot] [PATCH v2 9/14] sunxi: Enable UBI and NAND support Maxime Ripard
2016-11-22 12:58   ` Boris Brezillon
2016-11-22 15:24   ` Tom Rini
2016-11-22 15:47     ` Peter Robinson
2016-11-22 15:54     ` Maxime Ripard
2016-11-22 16:40       ` Tom Rini
2016-11-22 12:38 ` [U-Boot] [PATCH v2 10/14] sunxi: Add the default mtdids and mtdparts to our env Maxime Ripard
2016-11-22 15:18   ` Tom Rini
2016-11-22 12:38 ` [U-Boot] [PATCH v2 11/14] nand: sunxi: Add options for the SPL NAND configuration Maxime Ripard
2016-11-22 12:38 ` [U-Boot] [PATCH v2 12/14] scripts: sunxi: Build an raw SPL image Maxime Ripard
2016-11-22 13:06   ` Boris Brezillon
2016-11-22 16:20   ` Heiko Schocher
2016-11-22 12:38 ` [U-Boot] [PATCH v2 13/14] sunxi: Sync GR8 DTS and AXP209 with the kernel Maxime Ripard
2016-12-03 13:49   ` Jagan Teki
2016-12-05 10:41     ` Maxime Ripard
2016-11-22 12:38 ` [U-Boot] [PATCH v2 14/14] sunxi: Add support for the CHIP Pro Maxime Ripard
2016-12-04  7:19 ` [U-Boot] [PATCH v2 0/14] " Jagan Teki
2016-12-05 21:33   ` Jagan Teki
2016-12-07 15:10     ` Jagan Teki
2016-12-09  8:18     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170104101056.18a5069e@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox