From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 00/12] arm: aspeed: Basic support for Aspeed AST2500 part and eval board
Date: Wed, 4 Jan 2017 15:26:38 -0500 [thread overview]
Message-ID: <20170104202638.GU24312@bill-the-cat> (raw)
In-Reply-To: <20170104194656.124368-1-maxims@google.com>
On Wed, Jan 04, 2017 at 11:46:44AM -0800, Maxim Sloyko wrote:
> This series adds minimal support for AST2500 part and eval board,
> enough to boot EVB into prompt. It contains WDT, Timer, Sysreset,
> Clock (very basic) and SDRAM MC drivers, all written from scratch,
> using AST2500 datasheet. Aspeed's SDK was used only for reference.
> Given very limited documentation provided by Aspeed, some parts of SDRAM
> init sequence were basically rewritten to do the same thing that is done
> in Aspeed SDK, without real understanding of what is going on.
>
> The file layout closely follows the example of rk3288 chip and firefly-rk3288
> board.
>
> For the first round of reviews I'm mostly looking for a nod to add
> mach-aspeed and arch-aspeed directories, as well as for feedback
> on naming, file locations and overall approach.
Thanks for doing this. I'll review the individual patches for other
changes but in general:
> Maxim Sloyko (12):
> aspeed: Add mach-aspeed directory and basic Kconfig
> aspeed: Add support for Watchdot Timer
> aspeed: Add Timer Support
> aspeed: Add sysreset driver
> aspeed/ast2500: Device Tree and bindings for some of the clocks
> aspeed/ast2500: Add Clock Driver
> aspeed/ast2500: Helper function to get access to SCU
> aspeed/ast2500: Add SDRAM MC driver
> aspeed/ast2500: Common board init functions for ast2500 based boards
This can really be one patch. Or maybe 2-3 (wdt, timer, sysreset,
everything else). The stuff that one could lump together and say "this
must be here for the SoC to build and have minimal functionality" is one
patch. The changes that adds useful functionality is a patch each.
> aspeed: Common configuration parameters for aspeed boards
> aspeed: Device Tree for ast2500 Eval Board
> aspeed: Configuration for ast2500 eval board
Adding the ast2500 EVB would be another single patch.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170104/9f5dd612/attachment.sig>
next prev parent reply other threads:[~2017-01-04 20:26 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 19:46 [U-Boot] [PATCH 00/12] arm: aspeed: Basic support for Aspeed AST2500 part and eval board Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 01/12] aspeed: Add mach-aspeed directory and basic Kconfig Maxim Sloyko
2017-01-04 19:58 ` Rick Altherr
2017-01-04 20:23 ` Tom Rini
2017-01-14 17:13 ` Simon Glass
2017-01-18 0:15 ` Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 02/12] aspeed: Add support for Watchdot Timer Maxim Sloyko
2017-01-04 20:58 ` Tom Rini
2017-01-14 17:13 ` Simon Glass
2017-01-04 19:46 ` [U-Boot] [PATCH 03/12] aspeed: Add Timer Support Maxim Sloyko
2017-01-04 20:58 ` Tom Rini
2017-01-14 17:13 ` Simon Glass
2017-01-17 17:57 ` Maxim Sloyko
2017-01-17 21:37 ` Simon Glass
2017-01-17 23:59 ` Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 04/12] aspeed: Add sysreset driver Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-04 19:46 ` [U-Boot] [PATCH 05/12] aspeed/ast2500: Device Tree and bindings for some of the clocks Maxim Sloyko
2017-01-04 20:58 ` Tom Rini
2017-01-05 1:18 ` Maxim Sloyko
2017-01-05 3:26 ` Tom Rini
2017-01-05 22:20 ` Maxim Sloyko
2017-01-14 17:13 ` Simon Glass
2017-01-17 23:27 ` Maxim Sloyko
2017-01-21 3:52 ` Simon Glass
2017-01-23 17:52 ` Maxim Sloyko
2017-01-23 19:51 ` Simon Glass
2017-01-04 19:46 ` [U-Boot] [PATCH 06/12] aspeed/ast2500: Add Clock Driver Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-17 23:18 ` Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 07/12] aspeed/ast2500: Helper function to get access to SCU Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-17 22:27 ` Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 08/12] aspeed/ast2500: Add SDRAM MC driver Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-18 20:16 ` Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 09/12] aspeed/ast2500: Common board init functions for ast2500 based boards Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-17 20:17 ` Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 10/12] aspeed: Common configuration parameters for aspeed boards Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-17 20:02 ` Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 11/12] aspeed: Device Tree for ast2500 Eval Board Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-17 19:51 ` Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 12/12] aspeed: Configuration for ast2500 eval board Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-17 19:46 ` Maxim Sloyko
2017-01-21 3:51 ` Simon Glass
2017-01-04 20:26 ` Tom Rini [this message]
2017-01-04 22:47 ` [U-Boot] [PATCH 00/12] arm: aspeed: Basic support for Aspeed AST2500 part and " Maxim Sloyko
2017-01-04 20:58 ` Tom Rini
2017-01-05 22:42 ` [U-Boot] [PATCH v1 0/4] " Maxim Sloyko
2017-01-05 22:42 ` [U-Boot] [PATCH v1 1/4] aspeed: Add drivers common to all Aspeed SoCs Maxim Sloyko
2017-01-05 22:42 ` [U-Boot] [PATCH v1 2/4] aspeed: Add basic ast2500 specific drivers and configuration Maxim Sloyko
2017-01-05 22:42 ` [U-Boot] [PATCH v1 3/4] aspeed: Board init functions and common configs for ast2500 based boards Maxim Sloyko
2017-01-05 22:42 ` [U-Boot] [PATCH v1 4/4] aspeed: Support for ast2500 Eval Board Maxim Sloyko
2017-01-10 1:50 ` [U-Boot] [PATCH v2 0/4] arm: aspeed: Basic support for Aspeed AST2500 part and eval board Maxim Sloyko
2017-01-10 1:50 ` [U-Boot] [PATCH v2 1/4] aspeed: Add drivers common to all Aspeed SoCs Maxim Sloyko
2017-01-11 3:20 ` Tom Rini
2017-01-10 1:50 ` [U-Boot] [PATCH v2 2/4] aspeed: Add basic ast2500 specific drivers and configuration Maxim Sloyko
2017-01-11 3:20 ` Tom Rini
2017-01-10 1:50 ` [U-Boot] [PATCH v2 3/4] aspeed: Board init functions and common configs for ast2500 based boards Maxim Sloyko
2017-01-11 3:20 ` Tom Rini
2017-01-11 23:40 ` Maxim Sloyko
2017-01-10 1:50 ` [U-Boot] [PATCH v2 4/4] aspeed: Support for ast2500 Eval Board Maxim Sloyko
2017-01-11 3:20 ` Tom Rini
2017-01-11 23:45 ` [U-Boot] [PATCH v3 0/4] arm: aspeed: Basic support for Aspeed AST2500 part and eval board Maxim Sloyko
2017-01-11 23:45 ` [U-Boot] [PATCH v3 1/4] aspeed: Add drivers common to all Aspeed SoCs Maxim Sloyko
2017-01-13 0:51 ` Tom Rini
2017-01-11 23:45 ` [U-Boot] [PATCH v3 2/4] aspeed: Add basic ast2500 specific drivers and configuration Maxim Sloyko
2017-01-11 23:45 ` [U-Boot] [PATCH v3 3/4] aspeed: Board init functions and common configs for ast2500 based boards Maxim Sloyko
2017-01-13 0:51 ` Tom Rini
2017-01-11 23:45 ` [U-Boot] [PATCH v3 4/4] aspeed: Support for ast2500 Eval Board Maxim Sloyko
2017-01-13 0:51 ` Tom Rini
2017-01-18 21:44 ` [U-Boot] [PATCH v4 0/4] arm: aspeed: Basic support for Aspeed AST2500 part and eval board Maxim Sloyko
2017-01-18 21:44 ` [U-Boot] [PATCH v4 1/4] aspeed: Add drivers common to all Aspeed SoCs Maxim Sloyko
2017-01-26 14:23 ` Simon Glass
2017-01-26 18:31 ` Maxim Sloyko
2017-01-28 22:44 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-01-18 21:44 ` [U-Boot] [PATCH v4 2/4] aspeed: Add basic ast2500-specific drivers and configuration Maxim Sloyko
2017-01-26 14:23 ` Simon Glass
2017-01-26 18:02 ` Maxim Sloyko
2017-01-28 22:44 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-01-18 21:44 ` [U-Boot] [PATCH v4 3/4] aspeed: Board init functions and common configs for ast2500 based boards Maxim Sloyko
2017-01-26 14:23 ` Simon Glass
2017-01-28 22:44 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-01-18 21:44 ` [U-Boot] [PATCH v4 4/4] aspeed: Support for ast2500 Eval Board Maxim Sloyko
2017-01-26 14:23 ` Simon Glass
2017-01-28 22:44 ` [U-Boot] [U-Boot, v4, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104202638.GU24312@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox