From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 4 Jan 2017 15:58:22 -0500 Subject: [U-Boot] [PATCH 00/12] arm: aspeed: Basic support for Aspeed AST2500 part and eval board In-Reply-To: <20170104194656.124368-1-maxims@google.com> References: <20170104194656.124368-1-maxims@google.com> Message-ID: <20170104205822.GV24312@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jan 04, 2017 at 11:46:44AM -0800, Maxim Sloyko wrote: > This series adds minimal support for AST2500 part and eval board, > enough to boot EVB into prompt. It contains WDT, Timer, Sysreset, > Clock (very basic) and SDRAM MC drivers, all written from scratch, > using AST2500 datasheet. Aspeed's SDK was used only for reference. > Given very limited documentation provided by Aspeed, some parts of SDRAM > init sequence were basically rewritten to do the same thing that is done > in Aspeed SDK, without real understanding of what is going on. > > The file layout closely follows the example of rk3288 chip and firefly-rk3288 > board. > > For the first round of reviews I'm mostly looking for a nod to add > mach-aspeed and arch-aspeed directories, as well as for feedback > on naming, file locations and overall approach. I have a few minor comments I'll reply with but in a number of patches you add C/H files without a header/SPDX tag on them and that's a no-no. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: