[U-Boot] [PATCH v2 3/4] aspeed: Board init functions and common configs for ast2500 based boards

Maxim Sloyko
2017-01-11T23:40:22Z

On Tue, Jan 10, 2017 at 7:20 PM, Tom Rini <trini@konsulko.com> wrote:
> On Mon, Jan 09, 2017 at 05:50:39PM -0800, Maxim Sloyko wrote:
>
> [snip]
>> +#define CONFIG_CMDLINE_EDITING 1
>
> In general, we just do '#define CONFIG_FOO'.

Fixed several defines in aspeed-common.h and evb_ast2500.h

>
>> +#define CONFIG_SYS_TEXT_BASE 0x00000000
>
> This one at least is in Kconfig now. Please check for anything else
> that has also been migrated, thanks!

This seems to be the only one. Checked by grepping all Kconfigs for
all options in aspeed-common.h, basically by running

for v in $(cat include/configs/aspeed-common.h | awk '/^#define
CONFIG/ { print gensub("CONFIG_", "", 1, $2) }'); do find . -name
Kconfig -exec grep -Hn $v {} \; ; done

The fix still ended up being spread around three patches from this
series, so I'm copying Revewed-by to only one of those that was left
untouched.

>
> --
> Tom

--
Maxim Sloyko