[U-Boot] [PATCH 02/12] aspeed: Add support for Watchdot Timer

Simon Glass
2017-01-14T17:13:42Z

Hi Maxim,

On 4 January 2017 at 12:46, Maxim Sloyko <maxims@google.com> wrote:
> The driver is compatible with AST2400 and AST2500 watchdogs.
> There is no uclass for Watchdog yet, so the driver does not follow
> the driver model. It also uses fixed clock, so no clock driver
> is needed.
>
> # Conflicts:
> # arch/arm/mach-aspeed/Makefile
>
> Signed-off-by: Maxim Sloyko <maxims@google.com>
> ---
>
> arch/arm/include/asm/arch-aspeed/wdt.h | 89 ++++++++++++++++++++++++++++++++++
> arch/arm/mach-aspeed/Makefile | 3 +-
> arch/arm/mach-aspeed/ast_wdt.c | 44 +++++++++++++++++
> 3 files changed, 134 insertions(+), 2 deletions(-)
> create mode 100644 arch/arm/include/asm/arch-aspeed/wdt.h
> create mode 100644 arch/arm/mach-aspeed/ast_wdt.c
>
> diff --git a/arch/arm/include/asm/arch-aspeed/wdt.h b/arch/arm/include/asm/arch-aspeed/wdt.h
> new file mode 100644
> index 0000000000..32774b1a70
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-aspeed/wdt.h
> @@ -0,0 +1,89 @@
> +/*
> + * (C) Copyright 2016 Google, Inc
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#ifndef _ASM_ARCH_WDT_H
> +#define _ASM_ARCH_WDT_H
> +
> +#define WDT_BASE 0x1e785000

This should come from DT. I suggest creating a simple uclass for the
watchdog timer, so you can make this a proper driver-model driver.

Regards,
Simon