[U-Boot] [PATCH 07/12] aspeed/ast2500: Helper function to get access to SCU

Maxim Sloyko
2017-01-17T22:27:03Z

On Sat, Jan 14, 2017 at 9:14 AM, Simon Glass <sjg@chromium.org> wrote:

> Hi Maxim,
>
> On 4 January 2017 at 12:46, Maxim Sloyko <maxims@google.com> wrote:
> > Helper function to get access to SCU (System Control Unit) through Clock
> > driver. This is similar to rockchip_get_cru function, which was used as
> > an example.
> >
> > It will be used by other drivers to get access to SCU.
> >
> > Signed-off-by: Maxim Sloyko <maxims@google.com>
> > ---
> >
> > arch/arm/mach-aspeed/Kconfig | 2 ++
> > arch/arm/mach-aspeed/Makefile | 1 +
> > arch/arm/mach-aspeed/ast2500/Kconfig | 6 ++++++
> > arch/arm/mach-aspeed/ast2500/Makefile | 1 +
> > arch/arm/mach-aspeed/ast2500/clk_ast2500.c | 31
> ++++++++++++++++++++++++++++++
> > 5 files changed, 41 insertions(+)
> > create mode 100644 arch/arm/mach-aspeed/ast2500/Kconfig
> > create mode 100644 arch/arm/mach-aspeed/ast2500/Makefile
> > create mode 100644 arch/arm/mach-aspeed/ast2500/clk_ast2500.c
>
> The code seems fine.
>
> It seems odd that you have Kconfig changes here also. Why is that?
>

This was probably a mistake, looks like this does not apply to a series
with fewer patches.

>
> Regards,
> Simon
>

--
*M*axim *S*loyko