From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 11 Jan 2017 10:05:16 -0500 Subject: [U-Boot] [PATCH 2/4] omap3_igep00x0: Rework MACH_TYPE and status LED logic slightly In-Reply-To: References: <1484086928-2586-1-git-send-email-trini@konsulko.com> <1484086928-2586-2-git-send-email-trini@konsulko.com> Message-ID: <20170111150516.GS7532@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jan 11, 2017 at 03:59:17PM +0100, Enric Balletbo Serra wrote: > 2017-01-10 23:22 GMT+01:00 Tom Rini : > > The MACH_TYPE for IGEP0032 was never officially used and has been > > removed from upstream, so we must not use it. In order to remove this > > we need to rework the status LED logic. > > > > Cc: Enric Balletbo i Serra > > Signed-off-by: Tom Rini > > --- > > configs/igep0032_defconfig | 1 - > > include/configs/omap3_igep00x0.h | 5 ++--- > > 2 files changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/configs/igep0032_defconfig b/configs/igep0032_defconfig > > index dad8dfaf0c22..cd48e45171cb 100644 > > --- a/configs/igep0032_defconfig > > +++ b/configs/igep0032_defconfig > > @@ -3,7 +3,6 @@ CONFIG_OMAP34XX=y > > # CONFIG_SPL_EXT_SUPPORT is not set > > CONFIG_TARGET_OMAP3_IGEP00X0=y > > CONFIG_DISTRO_DEFAULTS=y > > -CONFIG_SYS_EXTRA_OPTIONS="MACH_TYPE=MACH_TYPE_IGEP0032" > > CONFIG_BOOTDELAY=3 > > CONFIG_SYS_CONSOLE_IS_IN_ENV=y > > CONFIG_SYS_CONSOLE_INFO_QUIET=y > > diff --git a/include/configs/omap3_igep00x0.h b/include/configs/omap3_igep00x0.h > > index 30d3aa897f1b..e6d7db0da692 100644 > > --- a/include/configs/omap3_igep00x0.h > > +++ b/include/configs/omap3_igep00x0.h > > @@ -28,7 +28,8 @@ > > #define CONFIG_REVISION_TAG 1 > > > > /* Status LED available for IGEP0020 and IGEP0030 but not IGEP0032 */ > > -#if (CONFIG_MACH_TYPE != MACH_TYPE_IGEP0032) > > +#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0020) || \ > > + (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0030) > > #define CONFIG_STATUS_LED > > #define CONFIG_BOARD_SPECIFIC_LED > > #define CONFIG_GPIO_LED > > @@ -36,8 +37,6 @@ > > #define RED_LED_GPIO 27 > > #elif (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0030) > > #define RED_LED_GPIO 16 > > -#else > > -#error "status LED not defined for this machine." > > #endif > > #define RED_LED_DEV 0 > > #define STATUS_LED_BIT RED_LED_GPIO > > -- > > 1.9.1 > > > > cc: Eduard and Pau > > I think that there are few boards in the field, an seems that anyone > take care to upstream the dts files to the kernel. Currently I don't > have this board so I can't support it, so from my side > > Acked-by: Enric Balletbo i Serra Note that all the above patch does is remove ATAGS-based support as the MACH_TYPE for the 0032 was reserved, but never used and thus the name was removed. DT based support is unchanged. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: