From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/4] cmd: mem: Use memcpy for 'cp' command
Date: Wed, 11 Jan 2017 11:21:19 -0500 [thread overview]
Message-ID: <20170111162119.GT7532@bill-the-cat> (raw)
In-Reply-To: <CAOMZO5Acx9HTQ23bCeohgeVJJW-mwdn01nZc3SSVnDP+fht75w@mail.gmail.com>
On Wed, Jan 11, 2017 at 01:49:55PM -0200, Fabio Estevam wrote:
> Hi Tom,
>
> On Mon, Dec 19, 2016 at 8:09 PM, Tom Rini <trini@konsulko.com> wrote:
> > On Thu, Dec 15, 2016 at 04:00:13PM -0200, Fabio Estevam wrote:
> >
> >> Simplify the 'cp' command implementation by using the memcpy() function,
> >> which brings the additional benefit of performance gain for those who have
> >> CONFIG_USE_ARCH_MEMCPY selected.
> >>
> >> Tested on a mx6qsabreauto board where a 5x gain in performance is seen
> >> when reading 10MB from the parallel NOR memory.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> >> ---
> >> Changes since v1:
> >> - Always use memcpy()
> >
> > I feel like this is correct. I also feel like it's too close to release
> > to do this, so I'll be applying this shortly after release, thanks!
>
> Is it a good time to apply this one now?
Yes, yes it would, thanks for the reminder. I'm kicking off a round of
testing in travis-ci now along with another pre-req of finally, really,
making arch/arm/lib/mem{set,cpy}.S be used by default in most cases.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170111/4ff919aa/attachment.sig>
next prev parent reply other threads:[~2017-01-11 16:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 18:00 [U-Boot] [PATCH v2 1/4] mx6qsabreauto: Configure the WEIM controller like the kernel Fabio Estevam
2016-12-15 18:00 ` [U-Boot] [PATCH v2 2/4] mx6qsabreauto: Pass the correct parallel NOR width Fabio Estevam
2017-01-27 9:33 ` Stefano Babic
2017-02-03 13:10 ` Fabio Estevam
2017-02-03 14:31 ` Stefano Babic
2016-12-15 18:00 ` [U-Boot] [PATCH v2 3/4] Kconfig: Move USE_ARCH_MEMCPY/MEMSET to Kconfig Fabio Estevam
2016-12-15 18:06 ` Tom Rini
2016-12-15 18:00 ` [U-Boot] [PATCH v2 4/4] cmd: mem: Use memcpy for 'cp' command Fabio Estevam
2016-12-17 15:11 ` Tom Rini
2016-12-19 22:09 ` Tom Rini
2016-12-19 22:11 ` Fabio Estevam
2017-01-11 15:49 ` Fabio Estevam
2017-01-11 16:21 ` Tom Rini [this message]
2017-01-13 0:51 ` [U-Boot] [U-Boot,v2,4/4] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111162119.GT7532@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox