From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 03/17] string: Use memcpy() within memmove() when we can
Date: Fri, 20 Jan 2017 07:07:38 -0700 [thread overview]
Message-ID: <20170120140752.16296-4-sjg@chromium.org> (raw)
In-Reply-To: <20170120140752.16296-1-sjg@chromium.org>
A common use of memmove() can be handled by memcpy(). Also memcpy()
includes an optimisation for large sizes: it copies a word at a time. So
we can get a speed-up by calling memcpy() to handle our move in this case.
Update memmove() to call memcpy() if the destination is before the source.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v4: None
Changes in v3: None
lib/string.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/lib/string.c b/lib/string.c
index 67d5f6a4213..6a75efb180b 100644
--- a/lib/string.c
+++ b/lib/string.c
@@ -509,16 +509,9 @@ void * memmove(void * dest,const void *src,size_t count)
{
char *tmp, *s;
- if (src == dest)
- return dest;
-
if (dest <= src) {
- tmp = (char *) dest;
- s = (char *) src;
- while (count--)
- *tmp++ = *s++;
- }
- else {
+ memcpy(dest, src, count);
+ } else {
tmp = (char *) dest + count;
s = (char *) src + count;
while (count--)
--
2.11.0.483.g087da7b7c-goog
next prev parent reply other threads:[~2017-01-20 14:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 14:07 [U-Boot] [PATCH v4 00/17] arm: rpi: Enable USB, Ethernet, MMC, Video driver model on Raspberry Pi Simon Glass
2017-01-20 14:07 ` [U-Boot] [PATCH v4 01/17] dm: mmc: Set up the MMC device when controller is probed Simon Glass
2017-01-24 6:21 ` Jaehoon Chung
2017-01-20 14:07 ` [U-Boot] [PATCH v4 02/17] dm: video: Correct line clearing code Simon Glass
2017-01-24 14:55 ` Anatolij Gustschin
2017-01-20 14:07 ` Simon Glass [this message]
2017-01-23 18:13 ` [U-Boot] [PATCH v4 03/17] string: Use memcpy() within memmove() when we can Tom Rini
2017-01-20 14:07 ` [U-Boot] [PATCH v4 04/17] arm: rpi: Drop the GPIO device addresses Simon Glass
2017-01-20 14:07 ` [U-Boot] [PATCH v4 05/17] arm: rpi: Drop CONFIG_CONS_INDEX Simon Glass
2017-01-20 14:07 ` [U-Boot] [PATCH v4 06/17] dm: arm: rpi: Move to driver model for USB Simon Glass
2017-01-20 14:07 ` [U-Boot] [PATCH v4 07/17] dm: arm: rpi: Use driver model for Ethernet Simon Glass
2017-01-20 14:07 ` [U-Boot] [PATCH v4 08/17] arm: rpi: Add a file to handle messages Simon Glass
2017-01-20 14:07 ` [U-Boot] [PATCH v4 09/17] arm: rpi: Add a function to obtain the MMC clock Simon Glass
2017-01-20 14:07 ` [U-Boot] [PATCH v4 10/17] dm: mmc: rpi: Convert Raspberry Pi to driver model for MMC Simon Glass
2017-01-24 6:51 ` Jaehoon Chung
2017-01-20 14:07 ` [U-Boot] [PATCH v4 11/17] dm: arm: rpi: Drop CONFIG_OF_EMBED Simon Glass
2017-01-20 14:07 ` [U-Boot] [PATCH v4 12/17] video: arm: rpi: Move the video query out of the driver Simon Glass
2017-01-24 14:51 ` Anatolij Gustschin
2017-01-20 14:07 ` [U-Boot] [PATCH v4 13/17] video: arm: rpi: Move the video settings " Simon Glass
2017-01-24 14:52 ` Anatolij Gustschin
2017-01-20 14:07 ` [U-Boot] [PATCH v4 14/17] dm: video: Refactor lcd_simplefb to prepare for driver model Simon Glass
2017-01-24 14:20 ` Anatolij Gustschin
2017-01-20 14:07 ` [U-Boot] [PATCH v4 15/17] dm: video: Add driver-model support to lcd_simplefb Simon Glass
2017-01-24 14:23 ` Anatolij Gustschin
2017-01-20 14:07 ` [U-Boot] [PATCH v4 16/17] dm: video: arm: rpi: Convert to use driver model for video Simon Glass
2017-01-24 14:29 ` Anatolij Gustschin
2017-01-20 14:07 ` [U-Boot] [PATCH v4 17/17] arm: rpi: Add a TODO to move all messages into the msg handler Simon Glass
2017-01-23 18:22 ` [U-Boot] [PATCH v4 00/17] arm: rpi: Enable USB, Ethernet, MMC, Video driver model on Raspberry Pi Tom Rini
2017-02-06 15:32 ` Simon Glass
2017-04-01 4:19 ` Simon Glass
2017-04-01 4:34 ` Simon Glass
2017-04-05 13:41 ` Tom Rini
2017-04-05 22:25 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120140752.16296-4-sjg@chromium.org \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox