public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] config: Move CONFIG_BOARD_LATE_INIT to defconfigs
Date: Sat, 21 Jan 2017 23:09:20 -0500	[thread overview]
Message-ID: <20170122040920.GX25981@bill-the-cat> (raw)
In-Reply-To: <CAK7LNASR1YjQsgfuobLQ5szOK7zj2piZNvKzHakVYTHLHa1G+g@mail.gmail.com>

On Sun, Jan 22, 2017 at 12:45:44PM +0900, Masahiro Yamada wrote:
> Hi.
> 
> 
> 2017-01-22 8:02 GMT+09:00 Tom Rini <trini@konsulko.com>:
> > On Sat, Jan 21, 2017 at 11:48:33AM +0100, Jagan Teki wrote:
> >
> >> Cc: Tom Rini <trini@konsulko.com>
> >> Signed-off-by: Jagan Teki <jagan@openedev.com>
> >
> > Note: theadorable_debug grows by ~161 bytes in SPL as it had been
> > enabling BOARD_LATE_INIT only for non-SPL which is now not allowed.
> >
> > Applied to u-boot/master, thanks!
> 
> Now, CONFIG_BOARD_LATE_INIT can be enabled/disabled
> from menuconfig, but generally this is not user-configurable
> because disabling it will skip needed init procedure.
> 
> I thought the right thing to do was
>   [1] Make each board "select BOARD_LATE_INIT"
> 
>         or
> 
>   [2] Change board_late_init() into a weak function so that
>        each board file can overrides it, then deprecate
>        CONFIG_BOARD_LATE_INIT.

In the fullness of time this should become a select, I agree.  However,
it's more than a bit difficult to figure out where to, and then
automatically whack in, a 'select' line.  I have something almost
working locally (that I'll just need to fixup the Kconfig files in,
after adding lines close to where they go) but like things that we can
clean up once 'imply' is a valid word, we really need to get things
converted, and then cleaned up.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170121/ddcca1bc/attachment.sig>

  reply	other threads:[~2017-01-22  4:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-21 10:48 [U-Boot] [PATCH 1/2] common: Kconfig: Add BOARD_LATE_INIT entry Jagan Teki
2017-01-21 10:48 ` [U-Boot] [PATCH 2/2] config: Move CONFIG_BOARD_LATE_INIT to defconfigs Jagan Teki
2017-01-21 23:02   ` Tom Rini
2017-01-22  3:45     ` Masahiro Yamada
2017-01-22  4:09       ` Tom Rini [this message]
2017-01-22 14:41         ` Tom Rini
2017-01-21 23:02 ` [U-Boot] [PATCH 1/2] common: Kconfig: Add BOARD_LATE_INIT entry Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170122040920.GX25981@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox