public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] disk: convert to Kconfig
Date: Tue, 24 Jan 2017 22:26:29 -0500	[thread overview]
Message-ID: <20170125032629.GD22316@bill-the-cat> (raw)
In-Reply-To: <1485251815-19040-1-git-send-email-patrick.delaunay73@gmail.com>

On Tue, Jan 24, 2017 at 10:56:55AM +0100, Patrick Delaunay wrote:

> From: Patrick Delaunay <patrick.delaunay@st.com>
> 
> This converts the following to Kconfig:
>            CONFIG_PARTITIONS
>            CONFIG_MAC_PARTITION
>            CONFIG_DOS_PARTITION
>            CONFIG_ISO_PARTITION
>            CONFIG_AMIGA_PARTITION
>            CONFIG_EFI_PARTITION
>            CONFIG_PARTITION_UUIDS
>            CONFIG_PARTITION_TYPE_GUID
> 
> Specific SPL config are added to reduce SPL size
> for some target and solve compilation issues
> 
>            CONFIG_SPL_MAC_PARTITION
>            CONFIG_SPL_DOS_PARTITION
>            CONFIG_SPL_ISO_PARTITION
>            CONFIG_SPL_AMIGA_PARTITION
>            CONFIG_SPL_EFI_PARTITION
> 
> Associated test are updated to the correct CONFIG (SPL or not)
> by using macro CONFIG_IS_ENABLED
> 
> To update the U-Boot code I use :
> 0- Resync with savedefconfig
>    /tools/moveconfig.py -s -Cy
> 
> 1- update defconfig for new SPL option
>    ./tools/moveconfig.py --spl --commit \
>            PARTITIONS MAC_PARTITION DOS_PARTITION \
>            ISO_PARTITION AMIGA_PARTITION EFI_PARTITION \
>            PARTITION_UUIDS PARTITION_TYPE_GUID
> 
>        then replace CONFIG by CONFIG_SPL in defconfig
>        sed -i "s/CONFIG_\(DOS\|EFI\|ISO\|MAC\|AMIGA\)_PARTITION/CONFIG_SPL_\1_PARTITION/" \
>            configs/*
> 
> 2- update defconfig for existing option
>    ./tools/moveconfig.py --commit --yes \
>            PARTITIONS MAC_PARTITION DOS_PARTITION \
>            ISO_PARTITION AMIGA_PARTITION EFI_PARTITION \
>            PARTITION_UUIDS PARTITION_TYPE_GUID
> 
>     => squash the 2 modifications
> 
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> Signed-off-by: Patrick Delaunay <patrick.delaunay73@gmail.com>

I played with this a lot tonight.  I think, sadly, we're going the wrong
direction in this conversion.  I believe I had originally suggested a
patch, but that's not right.  Lets get one patch per partition type, as
that will make finding and correcting the conversion easier.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170124/f52cc0ca/attachment.sig>

      reply	other threads:[~2017-01-25  3:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24  9:56 [U-Boot] [PATCH v4] disk: convert to Kconfig Patrick Delaunay
2017-01-25  3:26 ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170125032629.GD22316@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox