From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] env: Add support for FS environment
Date: Sat, 28 Jan 2017 15:02:49 -0500 [thread overview]
Message-ID: <20170128200249.GE22316@bill-the-cat> (raw)
In-Reply-To: <1485334393-179182-4-git-send-email-fiach.antaw@uqconnect.edu.au>
On Wed, Jan 25, 2017 at 06:53:13PM +1000, Fiach Antaw wrote:
> This patch adds support for fat/ext4-style environments on top of
> the FS api, allowing any filesystem to be used to store the u-boot
> environment. This implementation also support redundancy in the
> form of a secondary environment file on the same filesystem.
>
> Signed-off-by: Fiach Antaw <fiach.antaw@uqconnect.edu.au>
>
> ---
>
> README | 22 ++++++++
> cmd/nvedit.c | 1 +
> common/Makefile | 1 +
> common/env_fs.c | 126 +++++++++++++++++++++++++++++++++++++++++++
> include/environment.h | 16 ++++++
> scripts/config_whitelist.txt | 5 ++
> 6 files changed, 171 insertions(+)
> create mode 100644 common/env_fs.c
Functionally, I like this idea, it's a step in the right direction. My
first question is, did you test this on some real hardware that's using
environment stored in a filesystem, on another media not listed here
(say SATA?) ?
Second, it's really, really, not a good idea to add more Kconfig options
to the whitelist. Can you please take a look at starting to move the
env choices to Kconfig (I would assume ENV_IS_NOWHERE would be the
easiest to move) ? Then we can add this there, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170128/43fde886/attachment.sig>
prev parent reply other threads:[~2017-01-28 20:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 8:53 [U-Boot] [PATCH 0/3] env: Add support for environments on arbitrary filesystems Fiach Antaw
2017-01-25 8:53 ` [U-Boot] [PATCH 1/3] env: Add generic redundant environment implementation Fiach Antaw
2017-01-28 20:03 ` Tom Rini
2017-07-25 0:42 ` [U-Boot] [U-Boot, " Tom Rini
2017-01-25 8:53 ` [U-Boot] [PATCH 2/3] env: Switch env_nand, env_mmc and env_ubi to env_import_redund Fiach Antaw
2017-01-28 20:02 ` Tom Rini
2017-07-25 0:42 ` [U-Boot] [U-Boot, " Tom Rini
2017-01-25 8:53 ` [U-Boot] [PATCH 3/3] env: Add support for FS environment Fiach Antaw
2017-01-28 20:02 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170128200249.GE22316@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox