From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: 16550: properly initialize fcr field of ns16550_platdata
Date: Wed, 1 Feb 2017 08:12:16 -0500 [thread overview]
Message-ID: <20170201131216.GL5096@bill-the-cat> (raw)
In-Reply-To: <20170201011520.54462-1-gonzo@bluezbox.com>
On Tue, Jan 31, 2017 at 05:15:20PM -0800, Oleksandr Tymoshenko wrote:
> Default fcr value is initialized in ns16550_serial_ofdata_to_platdata
> but this function is only called if OF_CONTROL option is enabled while
> the field is used whenever DM_SERIAL is set. So for configs that
> do not have OF_CONTROL default fcr value is set to zero which leads
> to loosing characters when serial port input is faster than reading
> routine i.e. when copy-pasting long line to U-Boot prompt.
>
> As a fix initialize fcr field in probe method
>
> Signed-off-by: Oleksandr Tymoshenko <gonzo@bluezbox.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>
Are you still seeing this with v2017.03-rc1? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170201/9612247f/attachment.sig>
next prev parent reply other threads:[~2017-02-01 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 1:15 [U-Boot] [PATCH] serial: 16550: properly initialize fcr field of ns16550_platdata Oleksandr Tymoshenko
2017-02-01 8:46 ` Marek Vasut
2017-02-01 13:12 ` Tom Rini [this message]
2017-02-01 18:52 ` Oleksandr Tymoshenko
2017-02-02 5:13 ` Heiko Schocher
2017-02-02 5:36 ` Oleksandr Tymoshenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201131216.GL5096@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox