From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 2/3] spl: Remove overwrite of relocated malloc limit
Date: Wed, 1 Feb 2017 19:08:53 -0500 [thread overview]
Message-ID: <20170202000853.GP5096@bill-the-cat> (raw)
In-Reply-To: <59b3a4c3-b7b9-0f9b-41ec-12bb0487af07@arm.com>
On Wed, Feb 01, 2017 at 11:48:11PM +0000, Andr? Przywara wrote:
> On 27/01/17 16:39, Andrew F. Davis wrote:
>
> Hi,
>
> > spl_init on some boards is called after stack and heap relocation, on
> > some platforms spl_relocate_stack_gd is called to handle setting the
> > limit to its value CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN when simple
> > SPL malloc is enabled during relocation. spl_init should then not
> > re-assign the old pre-relocation limit when this is defined.
>
> I am sorry to say this, but this very patch breaks SPL boot on sunxi
> boards (tested on the Pine64, the Orangepi PC2 (with a similar ARMv8
> SoC) and the OrangePi Zero (ARMv7 Allwinner H3 SoC).
>
> U-Boot SPL 2017.03-rc1-00022-gf77309d (Feb 01 2017 - 23:27:19)
> DRAM: 1024 MiB
> Trying to boot from MMC1
> MMC Device 0 not found
> spl: could not find mmc device. error: -19
> SPL: failed to boot from all boot devices
> ### ERROR ### Please RESET the board ###
>
> sunxi boards both use the default CONFIG_SYS_MALLOC_F_LEN=0x400 and
> CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x100000.
>
> At the moment the code there is beyond me, so I can't really say how
> this breaks, but it clearly does: reverting this patch makes U-Boot
> happy again.
>
> Any ideas?
Arg. I'll try and poke at this but my A20-OLinuXino-Lime2 is (FEL at
least) booting so I hadn't seen this. Can you confirm that pine64, or
these other boards, also fail when FEL booting? I ask since if they
pass that way I need to pencil in some time to figure out another way to
test that HW, or at least make additional testing of that hardware
easier. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170201/3b566edd/attachment.sig>
next prev parent reply other threads:[~2017-02-02 0:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 16:39 [U-Boot] [PATCH v4 0/3] Add a config for AM335x High Security EVM Andrew F. Davis
2017-01-27 16:39 ` [U-Boot] [PATCH v4 1/3] malloc_simple: Add debug statements to memalign_simple Andrew F. Davis
2017-01-27 16:43 ` Tom Rini
2017-01-28 22:46 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-01-27 16:39 ` [U-Boot] [PATCH v4 2/3] spl: Remove overwrite of relocated malloc limit Andrew F. Davis
2017-01-27 16:43 ` Tom Rini
2017-01-28 22:46 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-02-01 23:48 ` [U-Boot] [PATCH v4 " André Przywara
2017-02-02 0:08 ` Tom Rini [this message]
2017-02-02 0:17 ` André Przywara
2017-02-02 5:35 ` Lokesh Vutla
2017-02-02 10:18 ` Andre Przywara
2017-01-27 16:39 ` [U-Boot] [PATCH v4 3/3] defconfig: Add a config for AM335x High Security EVM Andrew F. Davis
2017-01-28 22:46 ` [U-Boot] [U-Boot, v4, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202000853.GP5096@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox