public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] drivers: net: cpsw: Fix reading of mac address for am43 SoCs
@ 2017-02-01  3:50 Lokesh Vutla
  2017-02-01  4:10 ` Lokesh Vutla
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Lokesh Vutla @ 2017-02-01  3:50 UTC (permalink / raw)
  To: u-boot

cpsw driver tries to get macid for am43xx SoCs using the compatible
ti,am4372. But not all variants of am43x uses this complatible like
epos evm uses ti,am438x. So use a generic compatible ti,am43 to get
macid for all am43 based platforms.

Tested-by: Aparna Balasubramanian <aparnab@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 drivers/net/cpsw-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cpsw-common.c b/drivers/net/cpsw-common.c
index e828e85d8b..607eb4563c 100644
--- a/drivers/net/cpsw-common.c
+++ b/drivers/net/cpsw-common.c
@@ -110,7 +110,7 @@ int ti_cm_get_macid(struct udevice *dev, int slave, u8 *mac_addr)
 	if (of_device_is_compatible(dev, "ti,dm816-emac"))
 		return cpsw_am33xx_cm_get_macid(dev, 0x30, slave, mac_addr);
 
-	if (of_machine_is_compatible("ti,am4372"))
+	if (of_machine_is_compatible("ti,am43"))
 		return cpsw_am33xx_cm_get_macid(dev, 0x630, slave, mac_addr);
 
 	if (of_machine_is_compatible("ti,dra7"))
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] drivers: net: cpsw: Fix reading of mac address for am43 SoCs
  2017-02-01  3:50 [U-Boot] [PATCH] drivers: net: cpsw: Fix reading of mac address for am43 SoCs Lokesh Vutla
@ 2017-02-01  4:10 ` Lokesh Vutla
  2017-02-02 17:54 ` Joe Hershberger
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Lokesh Vutla @ 2017-02-01  4:10 UTC (permalink / raw)
  To: u-boot

+ Joe

On Wednesday 01 February 2017 09:20 AM, Lokesh Vutla wrote:
> cpsw driver tries to get macid for am43xx SoCs using the compatible
> ti,am4372. But not all variants of am43x uses this complatible like
> epos evm uses ti,am438x. So use a generic compatible ti,am43 to get
> macid for all am43 based platforms.
> 
> Tested-by: Aparna Balasubramanian <aparnab@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
>  drivers/net/cpsw-common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/cpsw-common.c b/drivers/net/cpsw-common.c
> index e828e85d8b..607eb4563c 100644
> --- a/drivers/net/cpsw-common.c
> +++ b/drivers/net/cpsw-common.c
> @@ -110,7 +110,7 @@ int ti_cm_get_macid(struct udevice *dev, int slave, u8 *mac_addr)
>  	if (of_device_is_compatible(dev, "ti,dm816-emac"))
>  		return cpsw_am33xx_cm_get_macid(dev, 0x30, slave, mac_addr);
>  
> -	if (of_machine_is_compatible("ti,am4372"))
> +	if (of_machine_is_compatible("ti,am43"))
>  		return cpsw_am33xx_cm_get_macid(dev, 0x630, slave, mac_addr);
>  
>  	if (of_machine_is_compatible("ti,dra7"))
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] drivers: net: cpsw: Fix reading of mac address for am43 SoCs
  2017-02-01  3:50 [U-Boot] [PATCH] drivers: net: cpsw: Fix reading of mac address for am43 SoCs Lokesh Vutla
  2017-02-01  4:10 ` Lokesh Vutla
@ 2017-02-02 17:54 ` Joe Hershberger
  2017-02-06  2:37 ` Tom Rini
  2017-02-09  3:02 ` [U-Boot] " Tom Rini
  3 siblings, 0 replies; 5+ messages in thread
From: Joe Hershberger @ 2017-02-02 17:54 UTC (permalink / raw)
  To: u-boot

On Tue, Jan 31, 2017 at 9:50 PM, Lokesh Vutla <lokeshvutla@ti.com> wrote:
> cpsw driver tries to get macid for am43xx SoCs using the compatible
> ti,am4372. But not all variants of am43x uses this complatible like
> epos evm uses ti,am438x. So use a generic compatible ti,am43 to get
> macid for all am43 based platforms.
>
> Tested-by: Aparna Balasubramanian <aparnab@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>

Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] drivers: net: cpsw: Fix reading of mac address for am43 SoCs
  2017-02-01  3:50 [U-Boot] [PATCH] drivers: net: cpsw: Fix reading of mac address for am43 SoCs Lokesh Vutla
  2017-02-01  4:10 ` Lokesh Vutla
  2017-02-02 17:54 ` Joe Hershberger
@ 2017-02-06  2:37 ` Tom Rini
  2017-02-09  3:02 ` [U-Boot] " Tom Rini
  3 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2017-02-06  2:37 UTC (permalink / raw)
  To: u-boot

On Wed, Feb 01, 2017 at 09:20:49AM +0530, Lokesh Vutla wrote:

> cpsw driver tries to get macid for am43xx SoCs using the compatible
> ti,am4372. But not all variants of am43x uses this complatible like
> epos evm uses ti,am438x. So use a generic compatible ti,am43 to get
> macid for all am43 based platforms.
> 
> Tested-by: Aparna Balasubramanian <aparnab@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170205/845fdbbf/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] drivers: net: cpsw: Fix reading of mac address for am43 SoCs
  2017-02-01  3:50 [U-Boot] [PATCH] drivers: net: cpsw: Fix reading of mac address for am43 SoCs Lokesh Vutla
                   ` (2 preceding siblings ...)
  2017-02-06  2:37 ` Tom Rini
@ 2017-02-09  3:02 ` Tom Rini
  3 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2017-02-09  3:02 UTC (permalink / raw)
  To: u-boot

On Wed, Feb 01, 2017 at 09:20:49AM +0530, Lokesh Vutla wrote:

> cpsw driver tries to get macid for am43xx SoCs using the compatible
> ti,am4372. But not all variants of am43x uses this complatible like
> epos evm uses ti,am438x. So use a generic compatible ti,am43 to get
> macid for all am43 based platforms.
> 
> Tested-by: Aparna Balasubramanian <aparnab@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170208/93081c60/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-02-09  3:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-01  3:50 [U-Boot] [PATCH] drivers: net: cpsw: Fix reading of mac address for am43 SoCs Lokesh Vutla
2017-02-01  4:10 ` Lokesh Vutla
2017-02-02 17:54 ` Joe Hershberger
2017-02-06  2:37 ` Tom Rini
2017-02-09  3:02 ` [U-Boot] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox