public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/6] spl: Convert CONFIG_SPL_ABORT_ON_RAW_IMAGE into a positive option
Date: Tue, 14 Feb 2017 16:04:28 -0500	[thread overview]
Message-ID: <20170214210428.GU26129@bill-the-cat> (raw)
In-Reply-To: <86f4a5c2-934f-e6bc-515a-3f853c60620a@ti.com>

On Tue, Feb 14, 2017 at 02:32:42PM -0600, Andrew F. Davis wrote:
> On 02/14/2017 02:15 PM, Tom Rini wrote:
> > On Mon, Feb 13, 2017 at 12:47:36PM -0600, Andrew F. Davis wrote:
> > 
> >> CONFIG_SPL_ABORT_ON_RAW_IMAGE causes SPL to abort and move on when it
> >> encounters RAW images, express this same functionality as a positive
> >> option enabling support for RAW images: CONFIG_SPL_RAW_IMAGE_SUPPORT
> >>
> >> Signed-off-by: Andrew F. Davis <afd@ti.com>
> >> ---
> >>  Kconfig                           |  7 +++++++
> >>  README                            |  4 ----
> >>  common/spl/spl.c                  | 10 ++++++----
> >>  include/configs/imx6_spl.h        |  4 ++--
> >>  include/configs/socfpga_de1_soc.h |  2 +-
> > 
> > OK, with this in Kconfig, we need to migrate the appropriate configs/
> > files rather than tweak include/configs/ files again.  I think
> > moveconfig.py will be reasonable to run here given that you can pass a
> > list of defconfigs to look at (anything that sets CONFIG_IMX6 and so
> > on).  Thanks!
> 
> It does, and it removes the symbols I tweaked in the include/configs/
> automatically. The issue is that it also caused a lot of churn in the
> defconfig files as a lot of symbols have become out of order and get
> re-ordered. With other similar patches re-ordering defconfig symbols
> this would be trouble for you to merge and for me to rebase if it needs
> a re-spin. Maybe moveconfig.py could be done on your side when patches
> like this are taken?

So in this case, the way you deal with it is:
1) Do a moveconfig.py -s and commit the results.
2) Do the rest of your patches
3) Drop that first patch and post.  If it doesn't apply cleanly
(sometimes it in fact does), I end up dealing with the fallout.

It's easier for me to deal with fixing defconfig fails to apply than it
is to be sure that everything is migrated correctly and as intended.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170214/e8e51edb/attachment.sig>

  reply	other threads:[~2017-02-14 21:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13 18:47 [U-Boot] [PATCH v4 0/6] Allow disabling non-FIT image loading from SPL Andrew F. Davis
2017-02-13 18:47 ` [U-Boot] [PATCH v4 1/6] spl: Convert CONFIG_SPL_ABORT_ON_RAW_IMAGE into a positive option Andrew F. Davis
2017-02-14 20:15   ` Tom Rini
2017-02-14 20:32     ` Andrew F. Davis
2017-02-14 21:04       ` Tom Rini [this message]
2017-02-15 19:37         ` Andrew F. Davis
2017-02-13 18:47 ` [U-Boot] [PATCH v4 2/6] spl: Add option to enable SPL Legacy image support Andrew F. Davis
2017-02-14 20:16   ` Tom Rini
2017-02-13 18:47 ` [U-Boot] [PATCH v4 3/6] ARM: AM335x: Disable non-FIT based image loading for HS devices Andrew F. Davis
2017-02-14 20:16   ` Tom Rini
2017-02-13 18:47 ` [U-Boot] [PATCH v4 4/6] ARM: AM43xx: " Andrew F. Davis
2017-02-14 20:16   ` Tom Rini
2017-02-13 18:47 ` [U-Boot] [PATCH v4 5/6] ARM: AM57xx: " Andrew F. Davis
2017-02-14 20:17   ` Tom Rini
2017-02-13 18:47 ` [U-Boot] [PATCH v4 6/6] ARM: DRA7xx: " Andrew F. Davis
2017-02-14 20:17   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170214210428.GU26129@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox