From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/5] tools: omapimage: Fix size in header
Date: Wed, 15 Feb 2017 08:07:36 -0500 [thread overview]
Message-ID: <20170215130736.GD26129@bill-the-cat> (raw)
In-Reply-To: <c26618a5-ef5a-244c-f95b-5722e74dc379@ti.com>
On Wed, Feb 15, 2017 at 06:02:37PM +0530, Lokesh Vutla wrote:
> Hi Tom,
>
> On Friday 10 February 2017 08:37 PM, Lokesh Vutla wrote:
> > The size field in GP header that is expected by ROM is size of the
> > image + size of the header. But omapimage generates a gp header
> > only with size of the image as size field. Fix it
>
> Unfortunately this is not ture for Keystone2. K2 rom still expects only
> the image size but the $subject patch effects K2 as well. Can you please
> take the below patch instead?
> Let me know if you want me to resend the series.
Please just re-send the v4 of 1/5 so patchwork will pick it up
correctly, thanks!
>
> From 3cb059cca5af5cb7538a411b2386ee4c5f753f2e Mon Sep 17 00:00:00 2001
> From: Lokesh Vutla <lokeshvutla@ti.com>
> Date: Wed, 15 Feb 2017 16:06:00 +0530
> Subject: [PATCH v4] tools: omapimage: Fix size in header
>
> The size field in GP header that is expected by ROM is size of the
> image + size of the header. But omapimage generates a gp header
> only with size of the image as size field. Fix it
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> tools/omapimage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/omapimage.c b/tools/omapimage.c
> index 7198b3330d..e31b94ae4f 100644
> --- a/tools/omapimage.c
> +++ b/tools/omapimage.c
> @@ -143,7 +143,7 @@ static void omapimage_set_header(void *ptr, struct
> stat *sbuf, int ifd,
> toc++;
> memset(toc, 0xff, sizeof(*toc));
>
> - gph_set_header(gph, sbuf->st_size - OMAP_FILE_HDR_SIZE,
> + gph_set_header(gph, sbuf->st_size - OMAP_CH_HDR_SIZE + GPIMAGE_HDR_SIZE,
> params->addr, 0);
>
> if (strncmp(params->imagename, "byteswap", 8) == 0) {
> --
> 2.11.0
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170215/98940c5b/attachment.sig>
next prev parent reply other threads:[~2017-02-15 13:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 15:07 [U-Boot] [PATCH v3 0/5] ARM: DRA7: AM57xx: Enable SPL_DM Lokesh Vutla
2017-02-10 15:07 ` [U-Boot] [PATCH v3 1/5] tools: omapimage: Fix size in header Lokesh Vutla
2017-02-15 12:32 ` Lokesh Vutla
2017-02-15 13:07 ` Tom Rini [this message]
2017-02-10 15:07 ` [U-Boot] [PATCH v3 2/5] ARM: OMAP2+: define _image_binary_end to fix SPL_OF_CONTROL Lokesh Vutla
2017-03-21 18:07 ` [U-Boot] [U-Boot, v3, " Tom Rini
2017-02-10 15:07 ` [U-Boot] [PATCH v3 3/5] ARM: dts: OMAP5+: Add u-boot specific dtsi Lokesh Vutla
2017-03-21 18:07 ` [U-Boot] [U-Boot, v3, " Tom Rini
2017-02-10 15:07 ` [U-Boot] [PATCH v3 4/5] configs: am57xx_evm: Enable SPL_DM Lokesh Vutla
2017-03-21 18:07 ` [U-Boot] [U-Boot,v3,4/5] " Tom Rini
2017-02-10 15:07 ` [U-Boot] [PATCH v3 5/5] configs: dra7xx_evm: " Lokesh Vutla
2017-03-21 18:07 ` [U-Boot] [U-Boot,v3,5/5] " Tom Rini
2017-02-15 13:12 ` [U-Boot] [PATCH v4] tools: omapimage: Fix size in header Lokesh Vutla
2017-03-16 20:40 ` [U-Boot] [U-Boot,v4] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215130736.GD26129@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox