From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] cmd: sspi: Add an additional argument to set the bus frequency
Date: Fri, 17 Feb 2017 12:36:40 -0500 [thread overview]
Message-ID: <20170217173640.GS26129@bill-the-cat> (raw)
In-Reply-To: <1487352448-937-1-git-send-email-philipp.tomsich@theobroma-systems.com>
On Fri, Feb 17, 2017 at 06:27:28PM +0100, Philipp Tomsich wrote:
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Please add a bit more information here as to why you need this, in the
commit message.
[snip]
> + if (argc >= 5)
> + hz = simple_strtoul(argv[4], NULL, 10);
You need an else here to set hz to the previously used value. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170217/ea1b3c5b/attachment.sig>
next prev parent reply other threads:[~2017-02-17 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 17:27 [U-Boot] [PATCH v1] cmd: sspi: Add an additional argument to set the bus frequency Philipp Tomsich
2017-02-17 17:36 ` Tom Rini [this message]
2017-02-17 18:10 ` [U-Boot] [PATCH v2] " Philipp Tomsich
2017-02-17 22:56 ` Tom Rini
2017-02-25 8:54 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217173640.GS26129@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox