public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/7] ti: wdt: hwinit-common: Remove legacy watchdog disable code
Date: Mon, 20 Feb 2017 08:32:50 +0100	[thread overview]
Message-ID: <20170220083250.15d8ed2a@jawa> (raw)
In-Reply-To: <f35e0d80-5073-2a7e-37c2-bd771d847703@ti.com>

On Mon, 20 Feb 2017 12:12:05 +0530
Lokesh Vutla <lokeshvutla@ti.com> wrote:

> 
> 
> On Monday 20 February 2017 03:54 AM, Lukasz Majewski wrote:
> > This patch removes some legacy code inherited from omap4. It is
> > redundant to the code already available
> > in ./drivers/watchdog/omap_wdt.c
> > 
> > The code dates back to 2010:
> > "ARMV7: Add basic support for TI OMAP4"
> > SHA1: d34efc767d26d353e0257042080eec7012e5440f
> > 
> > In contemporary u-boot omap watchdog:
> > - Can be enabled in SPL:
> > TI watchdog is initialized in spl_board_init() (call to
> > hw_watchdog_init)
> > 
> > - Is explicitly disabled before making any changes of its registers
> > 
> > - Is re-enabled in init_func_watchdog_init() in ./common/board_f.c
> > with other architectures.
> > 
> > This patch removes silent watchdog disable on TI platform, which
> > caused lack of wdt protection in u-boot even when it was explicitly
> > enabled (in SPL) with CONFIG_HW_WATCHDOG.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> 
> Can you remove similar code from arch/arm/mach-omap2/am33xx/board.c
> also?

Ok, I will do it (and test on BBB). 

Please test/review other patches :-)

> 
> Thanks and regards,
> Lokesh
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

  reply	other threads:[~2017-02-20  7:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-19 22:24 [U-Boot] [PATCH 0/7] ti: wdt: Fixes for am57xx/dra7 Watchdog Lukasz Majewski
2017-02-19 22:24 ` Lukasz Majewski
2017-02-19 22:24 ` [U-Boot] [PATCH 1/7] ti: wdt: common: Make the wdt IP defines common for the TI platform Lukasz Majewski
2017-02-20  2:24   ` Tom Rini
2017-04-10 18:24   ` [U-Boot] [U-Boot, " Tom Rini
2017-02-19 22:24 ` [U-Boot] [PATCH 2/7] ti: wdt: omap5: Define WDT_BASE for omap5+ SoC Lukasz Majewski
2017-02-20  2:24   ` Tom Rini
2017-04-10 18:24   ` [U-Boot] [U-Boot, " Tom Rini
2017-02-19 22:24 ` [U-Boot] [PATCH 3/7] ti: wdt: omap: Disable watchdog timer before performing initialization Lukasz Majewski
2017-02-20  2:25   ` Tom Rini
2017-04-07 20:29     ` Lukasz Majewski
2017-04-10 18:24   ` [U-Boot] [U-Boot, " Tom Rini
2017-02-19 22:24 ` [U-Boot] [PATCH 4/7] ti: wdt: hwinit-common: Remove legacy watchdog disable code Lukasz Majewski
2017-02-20  2:25   ` Tom Rini
2017-02-20  6:42   ` Lokesh Vutla
2017-02-20  7:32     ` Lukasz Majewski [this message]
2017-02-19 22:24 ` [U-Boot] [PATCH 5/7] ti: wdt: omap5: Remove not needed struct watchdog definition Lukasz Majewski
2017-02-20  2:25   ` Tom Rini
2017-02-19 22:24 ` [U-Boot] [PATCH 6/7] ti: wdt: omap: Use CONFIG_HW_WATCHDOG_TIMEOUT_MS to specify watchdog timeout Lukasz Majewski
2017-02-20  2:23   ` Tom Rini
2017-02-19 22:24 ` [U-Boot] [PATCH 7/7] ti: wdt: Enable OMAP watchdog in u-boot's board_f.c Lukasz Majewski
2017-02-20  2:24   ` Tom Rini
2017-02-20  7:35     ` Lukasz Majewski
2017-02-20 12:11       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170220083250.15d8ed2a@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox