public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 0/2] Series to clean handle_XXX() in f_dfu.c
@ 2016-12-16 17:41 Patrick Delaunay
  2016-12-16 17:41 ` [U-Boot] [PATCH 1/2] usb: gadget: dfu: correct size for USB_REQ_DFU_GETSTATE result Patrick Delaunay
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Patrick Delaunay @ 2016-12-16 17:41 UTC (permalink / raw)
  To: u-boot


1/ DFU_GETSTATE response error

when the DFU device state is requested using libusb with DFU_GETSTATUS
a error is generated : LIBUSB_ERROR_IO

I see the issue with my programmer tools based on dfu with libusb
and I don't understood the actual code in U-Boot
(req->actual is updated but not req->lenght ?)

With the proposed patch, I aligned the code on the GETSTATUS behavior:
the correct lenght is provided in req->lenght as the other answer
and the issue is solved.

PS: the issue not see with dfu-util as the existing function
    dfu_get_state() is never called in main (with dfu-util 0.9)

    But I can reproduce the same issue with patched version of dfu-util
    to add call to this function, on the dfu-util master branch

diff --git a/src/main.c b/src/main.c
index 7f31d4c..d99ace9 100644
--- a/src/main.c
+++ b/src/main.c
@@ -535,6 +535,13 @@ dfustate:
        }

 status_again:
+       printf("Determining device state: ");
+       ret = dfu_get_state(dfu_root->dev_handle, dfu_root->interface);
+       if (ret < 0) {
+               errx(EX_IOERR, "error get_state: %s", libusb_error_name(ret));
+       }
+       printf("state = %s\n", dfu_state_to_string(ret));
+
        printf("Determining device status: ");
        ret = dfu_get_status(dfu_root, &status );
        if (ret < 0) {


2/ harmonize handle_getstatus() with other function

=> add return value with size of the buffer as
   - handle_getstate() add in part 1
   or existing functions
   - handle_dnload()
   - handle_upload()



Patrick Delaunay (2):
  usb: gadget: dfu: correct size for USB_REQ_DFU_GETSTATE result
  usb: gadget: dfu: add result for handle_getstatus()

 drivers/usb/gadget/f_dfu.c | 56 ++++++++++++++++++++--------------------------
 drivers/usb/gadget/f_dfu.h |  1 -
 2 files changed, 24 insertions(+), 33 deletions(-)

-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-21 22:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-16 17:41 [U-Boot] [PATCH 0/2] Series to clean handle_XXX() in f_dfu.c Patrick Delaunay
2016-12-16 17:41 ` [U-Boot] [PATCH 1/2] usb: gadget: dfu: correct size for USB_REQ_DFU_GETSTATE result Patrick Delaunay
2016-12-16 17:41 ` [U-Boot] [PATCH 2/2] usb: gadget: dfu: add result for handle_getstatus() Patrick Delaunay
2017-02-21 22:36 ` [U-Boot] [PATCH 0/2] Series to clean handle_XXX() in f_dfu.c Lukasz Majewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox